From c44739398d19a89f0e816fa4f88f0c4246850fb2 Mon Sep 17 00:00:00 2001 From: zombiej Date: Tue, 31 Aug 2021 14:38:15 +0800 Subject: [PATCH 1/3] 2.0.0-alpha.17 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 4634b289..4525da12 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "rc-cascader", - "version": "2.0.0-alpha.16", + "version": "2.0.0-alpha.17", "description": "cascade select ui component for react", "keywords": [ "react", From 9c38117a0dfb6561c3e94ec2bae78877ae6825b2 Mon Sep 17 00:00:00 2001 From: zombiej Date: Mon, 13 Sep 2021 14:14:45 +0800 Subject: [PATCH 2/3] fix: Add miss placement --- package.json | 2 +- src/Cascader.tsx | 15 ++++++++++++++- tests/index.spec.tsx | 5 +++++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 4525da12..44b4f5c8 100644 --- a/package.json +++ b/package.json @@ -65,7 +65,7 @@ "dependencies": { "@babel/runtime": "^7.12.5", "array-tree-filter": "^2.1.0", - "rc-tree-select": "~4.4.0-alpha.5", + "rc-tree-select": "~4.5.0-alpha.0", "rc-trigger": "^5.0.4", "rc-util": "^5.0.1", "warning": "^4.0.1" diff --git a/src/Cascader.tsx b/src/Cascader.tsx index 832d612b..60a4145b 100644 --- a/src/Cascader.tsx +++ b/src/Cascader.tsx @@ -4,7 +4,7 @@ import useMergedState from 'rc-util/lib/hooks/useMergedState'; import type { TreeSelectProps } from 'rc-tree-select'; import generate from 'rc-tree-select/lib/generate'; import type { FlattenDataNode } from 'rc-tree-select/lib/interface'; -import type { RefSelectProps } from 'rc-select/lib/generate'; +import type { RefSelectProps, Placement } from 'rc-select/lib/generate'; import OptionList from './OptionList'; import type { CascaderValueType, DataNode, FieldNames, ShowSearchType } from './interface'; import CascaderContext from './context'; @@ -98,6 +98,10 @@ interface BaseCascaderProps popupClassName?: string; dropdownClassName?: string; + /** @deprecated Use `placement` instead */ + popupPlacement?: Placement; + placement?: Placement; + /** @deprecated Use `onDropdownVisibleChange` instead */ onPopupVisibleChange?: (open: boolean) => void; onDropdownVisibleChange?: (open: boolean) => void; @@ -153,6 +157,8 @@ const Cascader = React.forwardRef((props: CascaderProps, ref: React.Ref { onDropdownVisibleChange?.(nextVisible); onPopupVisibleChange?.(nextVisible); @@ -349,6 +361,7 @@ const Cascader = React.forwardRef((props: CascaderProps, ref: React.Ref { popupVisible onPopupVisibleChange={onPopupVisibleChange} popupClassName="legacy-cls" + popupPlacement="topRight" />, ); @@ -464,8 +465,12 @@ describe('Cascader.Basic', () => { expect(errorSpy).toHaveBeenCalledWith( 'Warning: `popupClassName` is deprecated. Please use `dropdownClassName` instead.', ); + expect(errorSpy).toHaveBeenCalledWith( + 'Warning: `popupPlacement` is deprecated. Please use `placement` instead.', + ); expect(wrapper.exists('.legacy-cls')).toBeTruthy(); + expect(wrapper.find('Trigger').prop('popupPlacement')).toEqual('topRight'); errorSpy.mockRestore(); }); From 8392b27c44fd092ff2683d22cd7b8c3079de5020 Mon Sep 17 00:00:00 2001 From: zombiej Date: Mon, 13 Sep 2021 14:20:00 +0800 Subject: [PATCH 3/3] chore: rm jest deps --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index 44b4f5c8..c9f7dbf6 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,6 @@ "father": "^2.13.2", "gh-pages": "^3.1.0", "glob": "^7.1.6", - "jest": "^27.1.0", "np": "^6.0.0", "rc-form": "^2.4.0", "react": "^16.0.0",