add labelField and valueField for custom label field name and value field name #23
Conversation
4 commits
Mar 7, 2018
added
I think your PR is useful for ant-design/ant-design#9929 Could you finish it and add some test cases? @405go |
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
+ Coverage 92.2% 92.4% +0.19%
=========================================
Files 3 3
Lines 154 158 +4
Branches 50 54 +4
=========================================
+ Hits 142 146 +4
Misses 12 12
Continue to review full report at Codecov.
|
@afc163 ok, i have finished |
How about |
@afc163 It is a good ideal |
@afc163 now it is good |
@afc163 It is our project style,It has become a habit. |
This comment has been minimized.
This comment has been minimized.
misspell, it should be fieldNames |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add labelField and valueField for custom label field name and value field name, It is not should just use value and label