From fd7ab578eae139f15bb885bb4f73351bf4bd1a3c Mon Sep 17 00:00:00 2001 From: Arlair Date: Wed, 22 Aug 2018 22:49:59 +0800 Subject: [PATCH] Update Checkbox.jsx The checkbox tabIndex should be a number and I think should match the antd component shown here: https://github.com/ant-design/ant-design/blob/3ffc7f6ac207f45f1743b1b943dd24586b91152b/components/checkbox/Checkbox.tsx#L21 But after starting the pull request I noticed this was already done and suggested it be changed this number or string. Perhaps merge one of them as currently it is wrong and might save more people coming here to fix it. Cheers :) --- src/Checkbox.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Checkbox.jsx b/src/Checkbox.jsx index 6dab02c..2d8f148 100644 --- a/src/Checkbox.jsx +++ b/src/Checkbox.jsx @@ -18,7 +18,7 @@ export default class Checkbox extends React.Component { onBlur: PropTypes.func, onChange: PropTypes.func, onClick: PropTypes.func, - tabIndex: PropTypes.string, + tabIndex: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), readOnly: PropTypes.bool, autoFocus: PropTypes.bool, value: PropTypes.any,