-
Notifications
You must be signed in to change notification settings - Fork 141
chore: remove unused dependencies #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused dependencies #407
Conversation
|
@divyeshagrawal is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
概览从 变更
预估代码审查工作量🎯 1 (微小) | ⏱️ ~3 分钟
诗歌
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @divyeshagrawal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on project maintenance by removing an identified unused dependency. This action helps to reduce the project's overall footprint, potentially improve build performance, and keep the dependency list clean and relevant. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the @testing-library/user-event dependency. While this dependency is indeed unused and the removal is correct, I've added a comment highlighting an opportunity to improve the test suite's robustness by considering @testing-library/user-event over the currently used fireEvent for simulating user interactions.
| "@rc-component/np": "^1.0.4", | ||
| "@testing-library/jest-dom": "^6.1.4", | ||
| "@testing-library/react": "^16.3.0", | ||
| "@testing-library/user-event": "^14.5.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this dependency is currently unused, it's worth noting that @testing-library/user-event is generally recommended over fireEvent for simulating user interactions in tests. The project's tests currently use fireEvent (e.g., in tests/index.spec.tsx), which doesn't simulate real user behavior as closely as user-event does. For example, userEvent.click() fires pointer events, hover events, and focus/blur events, which fireEvent.click() does not.
For more robust and reliable tests, I'd recommend considering re-adding this dependency and refactoring your tests to use userEvent. If you decide to stick with fireEvent, then removing this dependency is fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 5 5
Lines 120 120
Branches 45 44 -1
=======================================
Hits 119 119
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
发布说明