Skip to content

Conversation

@divyeshagrawal
Copy link
Contributor

@divyeshagrawal divyeshagrawal commented Nov 3, 2025

Summary by CodeRabbit

发布说明

  • Chores
    • 更新开发依赖项配置。

@vercel
Copy link

vercel bot commented Nov 3, 2025

@divyeshagrawal is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

概览

package.json 中移除了开发依赖 @testing-library/user-event@^14.5.2。无功能性变更或控制流修改。

变更

代码内聚 / 文件 变更摘要
依赖移除
package.json
删除 devDependency:@testing-library/user-event@^14.5.2

预估代码审查工作量

🎯 1 (微小) | ⏱️ ~3 分钟

  • 变更范围极小,仅涉及单个依赖的移除
  • 无需验证逻辑或功能影响

诗歌

🐰 一个依赖悄然离去,
package.json 焕然一新,
代码更轻,负担更少,
兔子们欢呼雀跃~

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 拉取请求的标题为 "chore: remove unused dependencies",准确地描述了此提交的主要变更。根据原始摘要,该PR移除了package.json中的未使用的devDependency "@testing-library/user-event"。标题简洁明了,使用了标准的提交前缀格式(chore:),并准确概括了变更内容。
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c1eef5 and 4970bea.

📒 Files selected for processing (1)
  • package.json (0 hunks)
💤 Files with no reviewable changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Socket Security: Pull Request Alerts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @divyeshagrawal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on project maintenance by removing an identified unused dependency. This action helps to reduce the project's overall footprint, potentially improve build performance, and keep the dependency list clean and relevant.

Highlights

  • Dependency Removal: The @testing-library/user-event package has been removed from the project's devDependencies in package.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @testing-library/user-event dependency. While this dependency is indeed unused and the removal is correct, I've added a comment highlighting an opportunity to improve the test suite's robustness by considering @testing-library/user-event over the currently used fireEvent for simulating user interactions.

"@rc-component/np": "^1.0.4",
"@testing-library/jest-dom": "^6.1.4",
"@testing-library/react": "^16.3.0",
"@testing-library/user-event": "^14.5.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this dependency is currently unused, it's worth noting that @testing-library/user-event is generally recommended over fireEvent for simulating user interactions in tests. The project's tests currently use fireEvent (e.g., in tests/index.spec.tsx), which doesn't simulate real user behavior as closely as user-event does. For example, userEvent.click() fires pointer events, hover events, and focus/blur events, which fireEvent.click() does not.

For more robust and reliable tests, I'd recommend considering re-adding this dependency and refactoring your tests to use userEvent. If you decide to stick with fireEvent, then removing this dependency is fine.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.16%. Comparing base (2c1eef5) to head (4970bea).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files           5        5           
  Lines         120      120           
  Branches       45       44    -1     
=======================================
  Hits          119      119           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yoyo837 yoyo837 merged commit c1a28dc into react-component:master Nov 4, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants