New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard support. #84

Merged
merged 5 commits into from Apr 2, 2018

Conversation

Projects
None yet
6 participants
@kossel
Contributor

kossel commented Feb 8, 2018

I'm not very familiar with testing, can you have a look and let me know it this works?

@coveralls

This comment has been minimized.

coveralls commented Feb 8, 2018

Coverage Status

Coverage decreased (-2.5%) to 92.035% when pulling 7fbf41e on kossel:master into d16f6eb on react-component:master.

this.handleItemClick = this.handleItemClick.bind(this);
this.handleKeyPress = this.handleKeyPress.bind(this);
}
handleItemClick() {

This comment has been minimized.

@afc163

afc163 Feb 8, 2018

Member

Try handleItemClick = () => { instead of binding in constructor.

@@ -35,12 +49,14 @@ class CollapsePanel extends Component {
[`${prefixCls}-item-disabled`]: disabled,
}, className);
return (
<div className={itemCls} style={style} id={id} role="tablist">

This comment has been minimized.

@afc163

afc163 Feb 8, 2018

Member

Why remove role="tablist"?

This comment has been minimized.

@kossel

kossel Feb 8, 2018

Contributor

I just moved it down to an inner div, since what we want to focus would be the header instead of the whole panel.

@benjycui

This comment has been minimized.

Member

benjycui commented Feb 8, 2018

@afc163 实际使用起来的效果可以找 九向 review 一下。

@kossel

This comment has been minimized.

Contributor

kossel commented Mar 6, 2018

what happen to this PR?

@goodmind

This comment has been minimized.

goodmind commented Apr 1, 2018

is this going to be merged?

@@ -35,12 +43,14 @@ class CollapsePanel extends Component {
[`${prefixCls}-item-disabled`]: disabled,
}, className);
return (
<div className={itemCls} style={style} id={id} role="tablist">
<div className={itemCls} style={style} id={id} >

This comment has been minimized.

@afc163

afc163 Apr 2, 2018

Member
- id={id} >
+ id={id}>

@afc163 afc163 merged commit 42c4fb3 into react-component:master Apr 2, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-2.5%) to 92.035%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@afc163

This comment has been minimized.

Member

afc163 commented Apr 2, 2018

close #83

afc163 added a commit that referenced this pull request Apr 2, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Apr 2, 2018

1.9.0 bumped

@enzoferey

This comment has been minimized.

enzoferey commented Apr 11, 2018

Hi, I'm having issues with redux-form Field component passed to "header" prop of Panel component. I can delete characters in the input but I can't write. Working in rc-collapse 1.8.0 but not in 1.9.0.

How should we proceed?

@afc163 afc163 referenced this pull request Jun 30, 2018

Closed

Collapse supports ARIA #6017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment