Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor father #256

Merged
merged 2 commits into from Jul 27, 2020
Merged

Conversation

fireairforce
Copy link
Contributor

No description provided.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 25, 2020

This pull request fixes 5 alerts when merging dbd4f0d into 9b85c5d - view on LGTM.com

fixed alerts:

  • 4 for Superfluous trailing arguments
  • 1 for Potentially inconsistent state update

@vercel
Copy link

vercel bot commented Jul 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/nhd8ga0l6
✅ Preview: https://input-number-git-fork-fireairforce-update-father.react-component.vercel.app

@zombieJ zombieJ requested a review from 07akioni July 25, 2020 15:08
@afc163
Copy link
Member

afc163 commented Jul 26, 2020

ci 覆盖率怎么没了。

@fireairforce
Copy link
Contributor Author

fireairforce commented Jul 26, 2020

QuQ,我本地跑 npm run coverage 好像是能出来的 QuQ

@07akioni
Copy link
Contributor

QuQ,我本地跑 npm run coverage 好像是能出来的 QuQ

看看 CI 相关的配置

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 26, 2020

This pull request fixes 5 alerts when merging 4b6712f into 9b85c5d - view on LGTM.com

fixed alerts:

  • 4 for Superfluous trailing arguments
  • 1 for Potentially inconsistent state update

@fireairforce
Copy link
Contributor Author

我加了一下,重新试试看?QuQ

@zombieJ zombieJ merged commit 2bbb49f into react-component:master Jul 27, 2020
preCommit: {
eslint: true,
prettier: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我重新开个pr把这个补一下,好像还是没看到 CI 覆盖率出来。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants