chore: improve coverage and one minor bug fix #132
Conversation
| @@ -175,22 +175,8 @@ const Menu = createReactClass({ | |||
| return transitionName; | |||
| }, | |||
|
|
|||
| isInlineMode() { | |||
| return this.props.mode === 'inline'; | ||
| }, | ||
|
|
||
| lastOpenSubMenu() { |
| @@ -10,7 +10,7 @@ import { noop } from './util'; | |||
|
|
|||
| /* eslint react/no-is-mounted:0 */ | |||
|
|
|||
| const MenuItem = createReactClass({ | |||
There was a problem hiding this comment.
exporting only for test
src/MenuMixin.js
Outdated
| @@ -106,7 +101,7 @@ const MenuMixin = { | |||
| }, | |||
|
|
|||
| // all keyboard events callbacks run from here at first | |||
| onKeyDown(e, callback) { | |||
There was a problem hiding this comment.
form onKeyDown(e, callback) is not used anywhere
There was a problem hiding this comment.
callback 是给 rc-select 用的，这个 PR 的代码放 rc-select 里跑下 rc-select 的测试。
src/MenuMixin.js
Outdated
| } | ||
|
|
||
| return 1; | ||
| } else if (activeItem === undefined) { |
There was a problem hiding this comment.
activeItem is either null or an object, never hit undefined. null case will be taken care by caller.
| @@ -154,25 +141,10 @@ const MenuMixin = { | |||
| }, | |||
|
|
|||
| getFlatInstanceArray() { | |||
| let instanceArray = this.instanceArray; | |||
| const hasInnerArray = instanceArray.some((a) => { | |||
There was a problem hiding this comment.
since subIndex is always invalid, hasInnerArray will never be true.
| @@ -3,7 +3,7 @@ | |||
| exports[`Menu render renders horizontal menu correctly 1`] = ` | |||
| <ul | |||
| aria-activedescendant="" | |||
| class="rc-menu myMenu rc-menu-root rc-menu-vertical" | |||
| class="rc-menu myMenu rc-menu-root rc-menu-horizontal" | |||
There was a problem hiding this comment.
@yesmeck https://github.com/react-component/menu/pull/132/files#diff-ccd4e2639d6848cd0e377d2f79ad2178L36 这个地方的测试写的不对，测了vertical, horizontal, inline，但是实际上都默认为vertical了
tests/SubMenu.spec.js
Outdated
| subMenuInstance.componentWillUnmount(); | ||
|
|
||
| expect(onDestroy).toHaveBeenCalledWith('s1'); | ||
| }); |
There was a problem hiding this comment.
最好是写个组件去测试这种情况。
const App = () => (
<Menu>
{show && (
<SubMenu key="s1" title="submenu1" onDestroy={onDestroy}>
<MenuItem key="s1-1">1</MenuItem>
</SubMenu>
)}
</Menu>
);
const wrapper = mount(<App show />);
wrapper.setProps({ show: false });
|
CI failed. |
picodoth
force-pushed
the
adding-test
branch
3 times, most recently
from
334b9dc
to
e8f8130
Compare
|
@yesmeck revert了关于callback的改动，把当前branch放到rc-select里跑了测试，没问题 |
before:
after:
