perf: uninstall classnames, install clsx

[li-jia-nan]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@li-jia-nan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 45d53c2 and 5f9bdad.

📒 Files selected for processing (9)

• package.json (1 hunks)
• src/Divider.tsx (2 hunks)
• src/Menu.tsx (2 hunks)
• src/MenuItem.tsx (2 hunks)
• src/MenuItemGroup.tsx (2 hunks)
• src/SubMenu/PopupTrigger.tsx (2 hunks)
• src/SubMenu/SubMenuList.tsx (3 hunks)
• src/SubMenu/index.tsx (2 hunks)
• tests/Private.spec.tsx (3 hunks)

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch clsx-update

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @li-jia-nan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a performance optimization by migrating the project from the classnames utility library to clsx. This change involves updating the project's dependencies, adjusting import statements, and modifying all code where CSS class strings were dynamically constructed to leverage the more performant clsx library. Additionally, a minor adjustment was made to ensure displayName assignments are only included in non-production builds.

Highlights

• Dependency Update: The classnames package has been uninstalled and replaced with clsx in package.json.
• Codebase Migration: All instances of classnames imports and usage have been updated to clsx across various React components and test files.
• Build Optimization: The displayName assignment for SubMenuList has been wrapped in a production environment check, preventing unnecessary code in production builds.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	husky@​9.1.7
	rc-test@​7.1.2
	clsx@​2.1.1
	regenerator-runtime@​0.14.1
	less@​4.1.3 ⏵ 4.4.1	+1		+1
	gh-pages@​6.3.0
	dumi@​2.4.21
	rc-overflow@​1.4.1
	react@​19.1.1
	prettier@​2.8.8 ⏵ 3.6.2
	typescript@​5.9.2
	eslint-plugin-jest@​27.2.3 ⏵ 28.14.0	+1		+1	+1
	eslint-plugin-unicorn@​47.0.0 ⏵ 51.0.1	+1		+1
	react-dom@​18.3.1 ⏵ 19.1.1	+1		+1
	eslint@​8.57.1
	lint-staged@​15.5.2
	father@​4.6.6

View full report

[gemini-code-assist]

Code Review

This pull request replaces the classnames library with clsx for performance improvements, which is a good move. The migration has been applied to most files, but I've identified a critical issue in src/Divider.tsx where a usage of the old classNames function remains after the import was updated. This will lead to a runtime error and needs to be fixed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.72%. Comparing base (45d53c2) to head (5f9bdad).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #794   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          26       26           
  Lines         726      727    +1     
  Branches      198      199    +1     
=======================================
+ Hits          724      725    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.