Skip to content

Conversation

@jljsj33
Copy link
Member

@jljsj33 jljsj33 commented Sep 11, 2017

  1. subMenu 统一添加箭头, clsssName 为 arrow;

  2. 修复 demo 报错。。。

@jljsj33 jljsj33 requested a review from afc163 September 11, 2017 11:14
src/SubMenu.jsx Outdated
aria-haspopup="true"
>
{props.title}
<i className="arrow" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ant-menu-arrow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是 rc 的。。。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefixCls

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放出来自定义??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefixCls 是: rc-menu-submenu,,那就 rc-menu-submenu-arrow

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.019% when pulling b7c3f3c on unified-arrow into 8ea8b98 on master.

right: 16px;
line-height: 1.5em;
&:before {
content: "\f0da";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不需要了吧。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他三角用什么???这里就用图标吧。。。

src: url('http://cdn.bootcss.com/font-awesome/4.2.0/fonts/fontawesome-webfont.eot?#iefix&v=4.2.0') format('embedded-opentype'), url('http://cdn.bootcss.com/font-awesome/4.2.0/fonts/fontawesome-webfont.woff?v=4.2.0') format('woff'), url('http://cdn.bootcss.com/font-awesome/4.2.0/fonts/fontawesome-webfont.ttf?v=4.2.0') format('truetype'), url('http://cdn.bootcss.com/font-awesome/4.2.0/fonts/fontawesome-webfont.svg?v=4.2.0#fontawesomeregular') format('svg');
font-weight: normal;
font-style: normal;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段也可以删了。

@afc163 afc163 merged commit ff7370c into master Sep 12, 2017
@afc163 afc163 deleted the unified-arrow branch September 12, 2017 03:34
@afc163
Copy link
Member

afc163 commented Sep 12, 2017

rc-menu@5.1.0

@jljsj33
Copy link
Member Author

jljsj33 commented Sep 12, 2017

我正在用 border 画三角呢。。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants