From 22a61df870857039c7c3c3a7f0c51d558f6fa8f7 Mon Sep 17 00:00:00 2001 From: Kermit Date: Thu, 13 May 2021 16:52:31 +0800 Subject: [PATCH 1/2] chore: add role to clear button --- src/Picker.tsx | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/Picker.tsx b/src/Picker.tsx index 2463473ca..11b717bdc 100644 --- a/src/Picker.tsx +++ b/src/Picker.tsx @@ -98,9 +98,11 @@ type OmitPanelProps = Omit< 'onChange' | 'hideHeader' | 'pickerValue' | 'onPickerValueChange' >; -export type PickerBaseProps = {} & PickerSharedProps & OmitPanelProps>; +export type PickerBaseProps = {} & PickerSharedProps & + OmitPanelProps>; -export type PickerDateProps = {} & PickerSharedProps & OmitPanelProps>; +export type PickerDateProps = {} & PickerSharedProps & + OmitPanelProps>; export type PickerTimeProps = { picker: 'time'; @@ -109,7 +111,8 @@ export type PickerTimeProps = { * since `defaultOpenValue` will confuse user of current value status */ defaultOpenValue?: DateType; -} & PickerSharedProps & Omit>, 'format'>; +} & PickerSharedProps & + Omit>, 'format'>; export type PickerProps = | PickerBaseProps @@ -194,9 +197,8 @@ function InnerPicker(props: PickerProps) { const [selectedValue, setSelectedValue] = React.useState(mergedValue); // Operation ref - const operationRef: React.MutableRefObject = React.useRef( - null, - ); + const operationRef: React.MutableRefObject = + React.useRef(null); // Open const [mergedOpen, triggerInnerOpen] = useMergedState(false, { @@ -433,6 +435,7 @@ function InnerPicker(props: PickerProps) { triggerOpen(false); }} className={`${prefixCls}-clear`} + role="button" > {clearIcon || } From 1d7da217138e9257c8e572a9ec43a8aefbb93c29 Mon Sep 17 00:00:00 2001 From: Kermit Date: Thu, 13 May 2021 17:05:44 +0800 Subject: [PATCH 2/2] chore: update snapshot --- tests/__snapshots__/picker.spec.tsx.snap | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/__snapshots__/picker.spec.tsx.snap b/tests/__snapshots__/picker.spec.tsx.snap index b5278a8bd..62782d3e5 100644 --- a/tests/__snapshots__/picker.spec.tsx.snap +++ b/tests/__snapshots__/picker.spec.tsx.snap @@ -20,6 +20,7 @@ exports[`Picker.Basic icon 1`] = `