Skip to content

Conversation

@mjfwebb
Copy link
Contributor

@mjfwebb mjfwebb commented May 3, 2020

Changes strokeWidth to always equal strokeWidth.
Adds opacity set to 0 on 0 progress (ptg), otherwise 1.

Due to the CSS transition and element width race-condition there is a need to keep the width greater than 0.

Adds opacity set to 0 on 0 progress (ptg), otherwise 1.

Due to the CSS transition and element width race-condition there is a need to keep the width greater than 0.
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files           5        5           
  Lines         121      121           
  Branches       24       24           
=======================================
  Hits          119      119           
  Misses          2        2           
Impacted Files Coverage Δ
src/Circle.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2bb541...baf5f35. Read the comment docs.

@mjfwebb
Copy link
Contributor Author

mjfwebb commented May 3, 2020

PR in relation to this: ant-design/ant-design#9676

But I think it might also fix this:
#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants