Improve testing #144

yesmeck · 2016-12-02T09:37:25Z

覆盖率提高到了 96%。

-------------------|----------|----------|----------|----------|----------------|
File               |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-------------------|----------|----------|----------|----------|----------------|
All files          |    96.06 |    87.68 |    97.44 |    96.04 |                |
 DropdownMenu.jsx  |      100 |      100 |      100 |      100 |                |
 FilterMixin.js    |      100 |    91.11 |      100 |      100 |                |
 OptGroup.jsx      |      100 |      100 |      100 |      100 |                |
 Option.jsx        |      100 |      100 |      100 |      100 |                |
 Select.jsx        |    96.47 |    85.92 |      100 |    96.44 |... 451,529,533 |
 SelectTrigger.jsx |      100 |    95.45 |      100 |      100 |                |
 index.js          |      100 |      100 |      100 |      100 |                |
 util.js           |    86.15 |     82.5 |    93.33 |    86.15 |... 108,109,115 |
-------------------|----------|----------|----------|----------|----------------|

yesmeck · 2016-12-02T09:38:18Z

src/DropdownMenu.jsx

@@ -97,7 +97,7 @@ const DropdownMenu = React.createClass({

        clonedMenuItems = menuItems.map(item => {
          if (item.type === MenuItemGroup) {
-            const children = item.props.children.map(clone);
+            const children = React.Children.map(item.props.children, clone);


这里做了个小调整。

这个不能改的，不能用 map 的，map 会修改 key

不过很奇怪，我在测试里只给 MenuItemGroup 传一个 child 的话，这里的 item.props.children 就不是一个数组。但是实际使用的时候，只给一个 child 这里就是数组。

奥，实际使用的时候，children 是从 FilterMixin 过来的，所以是数组。

yesmeck · 2016-12-02T09:38:36Z

src/Select.jsx

@@ -364,6 +364,7 @@ const Select = React.createClass({
          }
        }
      } else if (isMultipleOrTags(props) && inputValue) {
+        // why not use setState?
        this.state.inputValue = this.getInputDOMNode().value = '';


这里没看懂为什么没用 setState。

coveralls · 2016-12-03T04:53:53Z

Coverage increased (+20.6%) to 95.591% when pulling e6b3bd9 on yesmeck:improve-testing into 579f4d4 on react-component:master.

yesmeck · 2016-12-05T09:12:43Z

@yiminghe 这样测试可以的话，后面再推广到其他组件吧。

coveralls · 2016-12-06T02:25:14Z

Coverage increased (+20.6%) to 95.591% when pulling 1377d78 on yesmeck:improve-testing into 579f4d4 on react-component:master.

yesmeck commented Dec 2, 2016

View reviewed changes

yesmeck changed the title ~~Add tons of tests.~~ Add tons of tests Dec 2, 2016

Add tons of tests.

e6b3bd9

yesmeck force-pushed the improve-testing branch from fd9135a to e6b3bd9 Compare December 3, 2016 04:51

yesmeck changed the title ~~Add tons of tests~~ Improve testing Dec 5, 2016

Remove jQuery

1377d78

yiminghe merged commit a00b2c4 into react-component:master Dec 6, 2016

yesmeck mentioned this pull request Dec 23, 2016

Introduce jest and enzyme react-component/tree#51

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve testing #144

Improve testing #144

yesmeck commented Dec 2, 2016

yesmeck Dec 2, 2016

yiminghe Dec 6, 2016

yesmeck Dec 6, 2016

yesmeck Dec 6, 2016 •

edited

Loading

yesmeck Dec 2, 2016

coveralls commented Dec 3, 2016

yesmeck commented Dec 5, 2016 •

edited

Loading

coveralls commented Dec 6, 2016

Improve testing #144

Improve testing #144

Conversation

yesmeck commented Dec 2, 2016

yesmeck Dec 2, 2016

Choose a reason for hiding this comment

yiminghe Dec 6, 2016

Choose a reason for hiding this comment

yesmeck Dec 6, 2016

Choose a reason for hiding this comment

yesmeck Dec 6, 2016 • edited Loading

Choose a reason for hiding this comment

yesmeck Dec 2, 2016

Choose a reason for hiding this comment

coveralls commented Dec 3, 2016

yesmeck commented Dec 5, 2016 • edited Loading

coveralls commented Dec 6, 2016

yesmeck Dec 6, 2016 •

edited

Loading

yesmeck commented Dec 5, 2016 •

edited

Loading