New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onCell add row index #222

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@yoyo837
Contributor

yoyo837 commented Jul 21, 2018

As title.

yoyo837 added some commits Jul 21, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Jul 21, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@ec5ce64). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #222   +/-   ##
=========================================
  Coverage          ?   93.58%           
=========================================
  Files             ?       17           
  Lines             ?      748           
  Branches          ?      196           
=========================================
  Hits              ?      700           
  Misses            ?       40           
  Partials          ?        8
Impacted Files Coverage Δ
src/TableCell.js 97.82% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5ce64...2cc1078. Read the comment docs.

@yesmeck

This comment has been minimized.

Member

yesmeck commented Jul 22, 2018

What's the scenario do you need the index? index is not reliable.

@yoyo837

This comment has been minimized.

Contributor

yoyo837 commented Jul 23, 2018

For handle different logic every cell.

image

@yesmeck yesmeck merged commit 78783cf into react-component:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yoyo837 yoyo837 deleted the yoyo837:oncell-add-row-index branch Oct 15, 2018

yoyo837 added a commit to yoyo837/ant-design that referenced this pull request Oct 15, 2018

@yoyo837 yoyo837 referenced this pull request Oct 15, 2018

Closed

update table docs #12643

5 of 10 tasks complete

yoyo837 added a commit to yoyo837/ant-design that referenced this pull request Oct 15, 2018

@yoyo837 yoyo837 referenced this pull request Oct 15, 2018

Merged

Table onCell add row index as second argument #12645

8 of 10 tasks complete

afc163 added a commit to ant-design/ant-design that referenced this pull request Oct 26, 2018

kimochg added a commit to kimochg/ant-design that referenced this pull request Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment