New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add expandIcon #236

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
4 participants
@kagd
Contributor

kagd commented Aug 31, 2018

This has the same changes as #187, but also includes the unit tests and examples.

This PR allows for overriding the default expand icon.
collapse
expand

Grant Klinsing
feature: add expandIcon
Allows overriding the default expand icon for row expanding
@codecov-io

This comment has been minimized.

codecov-io commented Aug 31, 2018

Codecov Report

Merging #236 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #236      +/-   ##
=========================================
+ Coverage   93.38%   93.4%   +0.01%     
=========================================
  Files          17      17              
  Lines         726     728       +2     
  Branches      208     209       +1     
=========================================
+ Hits          678     680       +2     
  Misses         40      40              
  Partials        8       8
Impacted Files Coverage Δ
src/ExpandableTable.js 98.21% <ø> (ø) ⬆️
src/ExpandableRow.js 97.56% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6babc0b...746561d. Read the comment docs.

@yesmeck yesmeck merged commit 159cd16 into react-component:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yesmeck

This comment has been minimized.

Member

yesmeck commented Oct 15, 2018

@yesmeck

This comment has been minimized.

Member

yesmeck commented Oct 15, 2018

Close #186

@sytolk

This comment has been minimized.

sytolk commented Nov 9, 2018

I have tested to change the default icon with this. But for the same data (with and without children properties) the results are different.
If I have expandIcon properties (the same from example) its have icon displayed on every node (without children properties).
If we have data with children: [ ] properties the result are displayed correctly only with default [+/-] icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment