From d74b445dc8c8156c3eb238fc84ae626e6504e2bd Mon Sep 17 00:00:00 2001
From: zombiej <smith3816@gmail.com>
Date: Tue, 14 Jan 2020 14:48:57 +0800
Subject: [PATCH 1/2] body add missing data-row-key

---
 src/Body/BodyRow.tsx | 3 +++
 src/Body/index.tsx   | 1 +
 2 files changed, 4 insertions(+)

diff --git a/src/Body/BodyRow.tsx b/src/Body/BodyRow.tsx
index 946685c07..15fa35fbb 100644
--- a/src/Body/BodyRow.tsx
+++ b/src/Body/BodyRow.tsx
@@ -32,6 +32,7 @@ export interface BodyRowProps<RecordType> {
   onRow: GetComponentProps<RecordType>;
   rowExpandable: (record: RecordType) => boolean;
   indent?: number;
+  rowKey: React.Key;
   getRowKey: GetRowKey<RecordType>;
   childrenColumnName: string;
 }
@@ -43,6 +44,7 @@ function BodyRow<RecordType extends { children?: RecordType[] }>(props: BodyRowP
     stickyOffsets,
     record,
     index,
+    rowKey,
     getRowKey,
     rowExpandable,
     onRow,
@@ -118,6 +120,7 @@ function BodyRow<RecordType extends { children?: RecordType[] }>(props: BodyRowP
   const baseRowNode = (
     <RowComponent
       {...additionalProps}
+      data-row-key={rowKey}
       className={classNames(
         className,
         `${prefixCls}-row`,
diff --git a/src/Body/index.tsx b/src/Body/index.tsx
index 2143a7a58..9eb9947b3 100644
--- a/src/Body/index.tsx
+++ b/src/Body/index.tsx
@@ -44,6 +44,7 @@ function Body<RecordType>({
         return [
           <BodyRow
             key={key}
+            rowKey={key}
             record={record}
             recordKey={key}
             index={index}

From 7c49632d4c318dcebd1a8db12052d069e05a9880 Mon Sep 17 00:00:00 2001
From: zombiej <smith3816@gmail.com>
Date: Tue, 14 Jan 2020 15:08:33 +0800
Subject: [PATCH 2/2] update test case

---
 tests/Table.spec.js                          | 17 +++++++++++++++++
 tests/__snapshots__/ExpandRow.spec.js.snap   | 14 ++++++++++++++
 tests/__snapshots__/FixedColumn.spec.js.snap | 18 ++++++++++++++++++
 tests/__snapshots__/Table.spec.js.snap       | 13 +++++++++++++
 4 files changed, 62 insertions(+)

diff --git a/tests/Table.spec.js b/tests/Table.spec.js
index ed5b14ca3..721ba169f 100644
--- a/tests/Table.spec.js
+++ b/tests/Table.spec.js
@@ -729,4 +729,21 @@ describe('Table.Basic', () => {
     );
     expect(wrapper.find('.test')).toHaveLength(1);
   });
+
+  it('component body should pass `data-row-key`', () => {
+    const wrapper = mount(
+      <Table
+        columns={[{ dataIndex: 'test' }]}
+        components={{ body: { row: props => <tr {...props} /> } }}
+        data={[{ test: 'bamboo', key: 'light' }]}
+      />,
+    );
+
+    expect(
+      wrapper
+        .find('tr')
+        .last()
+        .props()['data-row-key'],
+    ).toEqual('light');
+  });
 });
diff --git a/tests/__snapshots__/ExpandRow.spec.js.snap b/tests/__snapshots__/ExpandRow.spec.js.snap
index 880dabf1b..72d4645fe 100644
--- a/tests/__snapshots__/ExpandRow.spec.js.snap
+++ b/tests/__snapshots__/ExpandRow.spec.js.snap
@@ -36,6 +36,7 @@ exports[`Table.Expand childrenColumnName 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="0"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -56,6 +57,7 @@ exports[`Table.Expand childrenColumnName 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-1"
+            data-row-key="0"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -76,6 +78,7 @@ exports[`Table.Expand childrenColumnName 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="1"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -153,6 +156,7 @@ exports[`Table.Expand renders fixed column correctly work 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="0"
           >
             <td
               class="rc-table-cell rc-table-row-expand-icon-cell rc-table-cell-fix-left"
@@ -199,6 +203,7 @@ exports[`Table.Expand renders fixed column correctly work 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="1"
           >
             <td
               class="rc-table-cell rc-table-row-expand-icon-cell rc-table-cell-fix-left"
@@ -286,6 +291,7 @@ exports[`Table.Expand renders tree row correctly 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="0"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -306,6 +312,7 @@ exports[`Table.Expand renders tree row correctly 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-1"
+            data-row-key="0"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -326,6 +333,7 @@ exports[`Table.Expand renders tree row correctly 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="1"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -387,6 +395,7 @@ exports[`Table.Expand renders tree row correctly with different children 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="0"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -407,6 +416,7 @@ exports[`Table.Expand renders tree row correctly with different children 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="1"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -427,6 +437,7 @@ exports[`Table.Expand renders tree row correctly with different children 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="2"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -447,6 +458,7 @@ exports[`Table.Expand renders tree row correctly with different children 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="3"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -467,6 +479,7 @@ exports[`Table.Expand renders tree row correctly with different children 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="4"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
@@ -487,6 +500,7 @@ exports[`Table.Expand renders tree row correctly with different children 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="5"
           >
             <td
               class="rc-table-cell rc-table-cell-with-append"
diff --git a/tests/__snapshots__/FixedColumn.spec.js.snap b/tests/__snapshots__/FixedColumn.spec.js.snap
index 7fbbd61ed..384ec300b 100644
--- a/tests/__snapshots__/FixedColumn.spec.js.snap
+++ b/tests/__snapshots__/FixedColumn.spec.js.snap
@@ -106,6 +106,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="1"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -171,6 +172,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="2"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -236,6 +238,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="3"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -283,6 +286,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="4"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -330,6 +334,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="5"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -377,6 +382,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="6"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -424,6 +430,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="7"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -471,6 +478,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="8"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -518,6 +526,7 @@ exports[`Table.FixedColumn renders correctly scrollX - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="9"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -834,6 +843,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="1"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -899,6 +909,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="2"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -964,6 +975,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="3"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -1011,6 +1023,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="4"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -1058,6 +1071,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="5"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -1105,6 +1119,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="6"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -1152,6 +1167,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="7"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -1199,6 +1215,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="8"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
@@ -1246,6 +1263,7 @@ exports[`Table.FixedColumn renders correctly scrollXY - with data 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="9"
           >
             <td
               class="rc-table-cell rc-table-cell-fix-left"
diff --git a/tests/__snapshots__/Table.spec.js.snap b/tests/__snapshots__/Table.spec.js.snap
index 78078a647..8ef8a0b93 100644
--- a/tests/__snapshots__/Table.spec.js.snap
+++ b/tests/__snapshots__/Table.spec.js.snap
@@ -37,6 +37,7 @@ exports[`Table.Basic custom components renders correctly 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key0"
             name="my-body-row"
           >
             <td
@@ -48,6 +49,7 @@ exports[`Table.Basic custom components renders correctly 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key1"
             name="my-body-row"
           >
             <td
@@ -140,6 +142,7 @@ exports[`Table.Basic custom components renders fixed column and header correctly
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="0"
             name="my-body-row"
           >
             <td
@@ -259,6 +262,7 @@ exports[`Table.Basic internal api transformColumns 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key0"
           >
             <td
               class="rc-table-cell"
@@ -274,6 +278,7 @@ exports[`Table.Basic internal api transformColumns 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key1"
           >
             <td
               class="rc-table-cell"
@@ -326,6 +331,7 @@ exports[`Table.Basic renders colSpan correctly 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key0"
           >
             <td
               class="rc-table-cell"
@@ -336,6 +342,7 @@ exports[`Table.Basic renders colSpan correctly 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key1"
           >
             <td
               class="rc-table-cell"
@@ -385,6 +392,7 @@ exports[`Table.Basic renders correctly basic 1`] = `
         >
           <tr
             class="test-prefix-row test-prefix-row-level-0"
+            data-row-key="key0"
           >
             <td
               class="test-prefix-cell"
@@ -394,6 +402,7 @@ exports[`Table.Basic renders correctly basic 1`] = `
           </tr>
           <tr
             class="test-prefix-row test-prefix-row-level-0"
+            data-row-key="key1"
           >
             <td
               class="test-prefix-cell"
@@ -436,6 +445,7 @@ exports[`Table.Basic renders correctly no columns 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key0"
           >
             <td
               class="rc-table-cell"
@@ -443,6 +453,7 @@ exports[`Table.Basic renders correctly no columns 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key1"
           >
             <td
               class="rc-table-cell"
@@ -491,6 +502,7 @@ exports[`Table.Basic renders rowSpan correctly 1`] = `
         >
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key0"
           >
             <td
               class="rc-table-cell"
@@ -506,6 +518,7 @@ exports[`Table.Basic renders rowSpan correctly 1`] = `
           </tr>
           <tr
             class="rc-table-row rc-table-row-level-0"
+            data-row-key="key1"
           >
             <td
               class="rc-table-cell"