From 43cd851069097ea96cd1c987cf05050883a81aec Mon Sep 17 00:00:00 2001 From: Edvin CANDON Date: Sat, 1 Jan 2022 18:58:39 +0100 Subject: [PATCH 1/2] fix: SummaryCell triggering `onCell` warning --- src/Footer/Cell.tsx | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/Footer/Cell.tsx b/src/Footer/Cell.tsx index 097124d7f..4763c206f 100644 --- a/src/Footer/Cell.tsx +++ b/src/Footer/Cell.tsx @@ -44,13 +44,11 @@ export default function SummaryCell({ record={null} dataIndex={null} align={align} - render={() => ({ - children, - props: { - colSpan: mergedColSpan, - rowSpan, - }, - })} + additionalProps={{ + colSpan: mergedColSpan, + rowSpan + }} + render={() => children} {...fixedInfo} /> ); From a5eb54cf33cc445c0577704feccc9e32513026c0 Mon Sep 17 00:00:00 2001 From: afc163 Date: Sun, 2 Jan 2022 14:32:50 +0800 Subject: [PATCH 2/2] Apply suggestions from code review --- src/Footer/Cell.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Footer/Cell.tsx b/src/Footer/Cell.tsx index 4763c206f..ba0ffff44 100644 --- a/src/Footer/Cell.tsx +++ b/src/Footer/Cell.tsx @@ -44,10 +44,8 @@ export default function SummaryCell({ record={null} dataIndex={null} align={align} - additionalProps={{ - colSpan: mergedColSpan, - rowSpan - }} + colSpan={mergedColSpan} + rowSpan={rowSpan} render={() => children} {...fixedInfo} />