Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed for multiple time formats in the header time input #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hsource
Copy link

@hsource hsource commented Nov 24, 2021

Motivation

While testing with users, we found that users were often entering times like 11am or 12:30 and confused when the time picker wouldn't change to save those times.

Fix

Add a new prop called validFormats. This allows us to parse more formats than the default of 12:00 PM.

Testing

Tested in our own app that uses this (https://wanderlog.com)

Time picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant