feat(ssr): remove listener only if we added them #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! Let's start with fixing the failing CI, please. |
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
+ Coverage 96.95% 96.98% +0.03%
==========================================
Files 3 3
Lines 197 199 +2
Branches 51 53 +2
==========================================
+ Hits 191 193 +2
Misses 6 6
Continue to review full report at Codecov.
|
okonet
approved these changes
Nov 17, 2017
josephfrazier
added a commit
to josephfrazier/react-dropzone
that referenced
this pull request
Jul 14, 2018
This change fixes potential issues with SSR, similarly to react-dropzone#537
9 tasks
okonet
pushed a commit
that referenced
this pull request
Aug 18, 2018
Fixes #537 (potential issues with SSR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
I have a tree-walker running for SSR and although componentWillMount and componentWillUnmount will be called on server, componentDidMount will not. Therefore we can't remove eventListener for the null ref.
Does this PR introduce a breaking change?
No