Skip to content

Conversation

@billcz
Copy link
Contributor

@billcz billcz commented Jun 21, 2016

defaultPosition => position

@STRML
Copy link
Collaborator

STRML commented Jun 21, 2016

????
On Jun 21, 2016 1:13 AM, "billcz" notifications@github.com wrote:

defaultPosition => position

You can view, comment on, or merge this pull request online at:

#168
Commit Summary

  • defaultPosition => position

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#168, or mute the
thread
https://github.com/notifications/unsubscribe/ABJFPxnsl-S6zT9NlwkgDU_cjr1wCyTVks5qN4DzgaJpZM4I6ZEg
.

@nikolas
Copy link
Contributor

nikolas commented Jun 21, 2016

There could have been an explanation with this PR, but it looks like it does in fact correct a typo in the documentation. Currently, the comment above Draggable.position() says defaultPosition, not position.

@@ -121,7 +121,7 @@ export default class Draggable extends React.Component {
       *      let App = React.createClass({
       *          render: function () {
       *              return (
 -     *                  <Draggable defaultPosition={{x: 25, y: 25}}>
 +     *                  <Draggable position={{x: 25, y: 25}}>
       *                      <div>I start with transformX: 25px and transformY: 25px;</div>
       *                  </Draggable>
       *              );
      *          }
      *      });
      * ```
      */
     position: PropTypes.shape({
       x: PropTypes.number,
       y: PropTypes.number
     }),

@STRML STRML merged commit ead3474 into react-grid-layout:master Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants