From 9ed6036d564363ef213f3f13b30433ce1433fb3b Mon Sep 17 00:00:00 2001 From: Connor Burton Date: Thu, 23 Jul 2015 11:41:23 +0100 Subject: [PATCH] Changing translate(x, y) to translate3d(x, y, z) for hardware accelerated performance improvements --- lib/draggable.js | 3 +-- specs/draggable.spec.js | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/draggable.js b/lib/draggable.js index 2eba26f0..e55bd57f 100644 --- a/lib/draggable.js +++ b/lib/draggable.js @@ -211,7 +211,7 @@ function createCSSTransform(style) { // Replace unitless items with px var x = style.x + 'px'; var y = style.y + 'px'; - var out = {transform: 'translate(' + x + ',' + y + ')'}; + var out = {transform: 'translate3d(' + x + ',' + y + ', 0px)'}; // Add single prefixed property as well if (browserPrefix) { out[browserPrefix + 'Transform'] = out.transform; @@ -219,7 +219,6 @@ function createCSSTransform(style) { return out; } - // // End Helpers. // diff --git a/specs/draggable.spec.js b/specs/draggable.spec.js index c332b27c..ba85d84a 100644 --- a/specs/draggable.spec.js +++ b/specs/draggable.spec.js @@ -91,7 +91,7 @@ describe('react-draggable', function () { expect(called).toEqual(true); }); - it('should render with translate()', function () { + it('should render with translate3d()', function () { drag = TestUtils.renderIntoDocument(
@@ -107,7 +107,7 @@ describe('react-draggable', function () { TestUtils.Simulate.mouseUp(node); var style = node.getAttribute('style'); - expect(style.indexOf('transform: translate(100px, 100px);')).not.toEqual(-1); + expect(style.indexOf('transform: translate3d(100px, 100px, 0px);')).not.toEqual(-1); }); it('should add and remove user-select styles', function () {