improve build setting #11

kotarella1110 · 2020-06-14T15:52:24Z

improve rollup setting
- change output filename
  - dist/resolver.js to dist/index.js
  - dist/resolver.es.js to dist/index.esm.js
- support umd build
  - dist/index.umd.min.js
  - umd name is ReactHookFormResolvers
  - https://unpkg.com/@hookform/resolvers@0.0.4/dist/index.umd.min.js
  - https://cdn.jsdelivr.net/npm/@hookform/resolvers@0.0.4/dist/index.umd.min.js
improve eslint & prettier setting
improve package.json
- move react-hook-form from deps to peerDeps
- add husky and lint-staged
improve actions workflow
improve types improve types #12

improve types

kotarella1110 · 2020-06-15T15:17:35Z

package.json

+  "keywords": [
+    "scheme",
+    "validation",
+    "scheme-validation",
+    "hookform",
+    "react-hook-form",
+    "yup",
+    "joi",
+    "sperstruct",
+    "typescript"
+  ],


@bluebill1049 Is this keyword OK?

awesome! thanks

kotarella1110 · 2020-06-15T15:19:15Z

rollup.config.js

+  {
+    input: 'src/index.ts',
+    output: {
+      name: 'HookFormResolvers',


@bluebill1049 Is this umd name OK?
HookFormResolvers vs ReactHookFormResolvers vs Resolvers
please see umd example.

ReactHookFormResolvers 👍 what do you think? looks better at umd example.

we may use HookForm as the umd name of react-hook-form.
Which is better?

HookForm

HookFormResolvers

HookFormErrorMessage

HookFormDevtools

vs

ReactHookForm

ReactHookFormResolvers

ReactHookFormErrorMessage

ReactHookFormDevtools

actually maybe second one, what if one day we have angularHookForm? lol

Hahaha. if it has the potential to support Angular and Vue, I think ReactHookForm is better.
However, in that case we think it is necessary to reconsider the scope name (@hookform).
ex: @hookform to @react-hook-form

@hookform/vue is fine as well?

if we can change to @hookform/react later on.

awesome! I will change umd name from HookForm to ReactHookForm.

kotarella1110 · 2020-06-15T16:16:47Z

@bluebill1049 I will fix @hookform/devtools as well.

bluebill1049 · 2020-06-15T22:38:11Z

.npmignore

@@ -1,39 +0,0 @@
-example/


why remove this?

I fixed to use files, we can remove the .npmignore.

https://docs.npmjs.com/files/package.json#files

resolvers/package.json

Lines 13 to 15 in 57795af

"files": [

"dist"

],

can you do the same for react-hook-form?

yea! I will fix 👍

bluebill1049 · 2020-06-15T22:38:26Z

.prettierrc

@@ -1,4 +0,0 @@
-{


I moved prettier setting to .eslintrc.js.
I think it's more useful to be able to manage with one file.
What do you think?

resolvers/.eslintrc.js

Lines 15 to 21 in 57795af

'prettier/prettier': [

'error',

{

singleQuote: true,

trailingComma: 'all',

},

],

personally, I prefer to keep them separate. They are two different technology, then others may ask why not keep eslint inside prettier.

bluebill1049 · 2020-06-15T22:39:41Z

README.md


-[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/bluebill1049/@hookform/resolvers)&nbsp;[![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/react-hook-form)
+[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/react-hook-form/resolvers)
+[![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/react-hook-form)


Suggested change

[![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/react-hook-form)

I think going forward we are leaner toward github dicussion.

bluebill1049 · 2020-06-15T22:40:22Z

README.md

 [![npm](https://img.shields.io/bundlephobia/minzip/@hookform/resolvers?style=for-the-badge)](https://bundlephobia.com/result?p=@hookform/resolvers)

-[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/bluebill1049/@hookform/resolvers)&nbsp;[![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/react-hook-form)
+[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/react-hook-form/resolvers)


Suggested change

[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/react-hook-form/resolvers)

[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/react-hook-form/resolvers)

don't think anyone use it. let's remove it as well keep it clean and minimum.

bluebill1049

Awesome work and clean up! thank you.

bluebill1049

LGTM!

kotarella1110 · 2020-06-16T01:04:12Z

Would you also like to fix the output name of react-hook-form? Or do you want to leave it as is?

dist/react-hook-form.js to dist/index.js
dist/react-hook-form.es.js to dist/index.esm.js
dist/react-hook-form.umd.js to dist/index.umd.js
dist/react-hook-form.ie11.js to dist/index.ie11.js

https://github.com/react-hook-form/react-hook-form/blob/0fee0da0044e1cd3afa887fa046dd84e92e4ed44/package.json#L5-L6

bluebill1049 · 2020-06-16T01:14:49Z

Would you also like to fix the output name of react-hook-form? Or do you want to leave it as is?

dist/react-hook-form.js to dist/index.js

dist/react-hook-form.es.js to dist/index.esm.js

dist/react-hook-form.umd.js to dist/index.umd.js

dist/react-hook-form.ie11.js to dist/index.ie11.js

https://github.com/react-hook-form/react-hook-form/blob/0fee0da0044e1cd3afa887fa046dd84e92e4ed44/package.json#L5-L6

sounds good to me. as long as we can do a quick test, you can still easily find the source code under chrome developer tab.

kotarella1110 · 2020-06-16T01:32:46Z

I will fix it 👍

kotarella1110 · 2020-06-16T01:35:07Z

This PR includes a version release, which is better, squash merge or merge commit?

bluebill1049 · 2020-06-16T01:43:20Z

This PR includes a version release, which is better, squash merge or merge commit?

I normally run npm version at master and push the tag into master, but whatever works.

kotarella1110 · 2020-06-16T02:33:58Z

@bluebill1049 "Create a merge commit" OK?

bluebill1049 · 2020-06-16T02:40:48Z

squash merge, please :)

improve build setting

e87ce45

kotarella1110 changed the title ~~[WIIP] improve build setting~~ [WIP] improve build setting Jun 14, 2020

kotarella1110 added 15 commits June 15, 2020 12:46

update settings

e235d7f

improve workflow

cb05743

update workflow

16a1429

update README.md

f8b046f

upgrade packages

2c405bf

fix peerDeps

69220ef

improve types

42e1c5b

resolve conflicts

fad8eab

fix superstruct

9a1ec95

run lint

3cffb0f

fix prepublishOnly script

04601a3

resolve conflicts

f739a8b

0.0.4

01db8df

fix types

88b653a

Merge pull request #12 from react-hook-form/improve-types

57795af

improve types

kotarella1110 changed the title ~~[WIP] improve build setting~~ improve build setting Jun 15, 2020

kotarella1110 commented Jun 15, 2020

View reviewed changes

kotarella1110 requested a review from bluebill1049 June 15, 2020 15:21

bluebill1049 reviewed Jun 15, 2020

View reviewed changes

bluebill1049 approved these changes Jun 15, 2020

View reviewed changes

kotarella1110 added 3 commits June 16, 2020 09:11

update README.md

f22f332

separate prettier setting

6436eb1

chage umd name from HookFormResolvers to ReactHookFormResolvers

5b162fa

bluebill1049 approved these changes Jun 16, 2020

View reviewed changes

kotarella1110 merged commit 28948ec into master Jun 16, 2020

kotarella1110 deleted the improve-build-setting branch June 16, 2020 03:03

	'prettier/prettier': [
	'error',
	{
	singleQuote: true,
	trailingComma: 'all',
	},
	],

	[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/react-hook-form/resolvers)
	[![Tweet](https://img.shields.io/twitter/url/http/shields.io.svg?style=social)](https://twitter.com/intent/tweet?text=React+hooks+for+form+validation+without+the+hassle&url=https://github.com/react-hook-form/resolvers)

Uh oh!

improve build setting #11

improve build setting #11

Uh oh!

Conversation

kotarella1110 commented Jun 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kotarella1110 commented Jun 15, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kotarella1110 Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bluebill1049 left a comment

Choose a reason for hiding this comment

Uh oh!

bluebill1049 left a comment

Choose a reason for hiding this comment

Uh oh!

kotarella1110 commented Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bluebill1049 commented Jun 16, 2020

Uh oh!

kotarella1110 commented Jun 16, 2020

Uh oh!

kotarella1110 commented Jun 16, 2020

Uh oh!

bluebill1049 commented Jun 16, 2020

Uh oh!

kotarella1110 commented Jun 16, 2020

Uh oh!

bluebill1049 commented Jun 16, 2020

Uh oh!

Reviewers

Assignees

Labels

kotarella1110 commented Jun 14, 2020 •

edited

Loading

kotarella1110 Jun 16, 2020 •

edited

Loading

kotarella1110 commented Jun 16, 2020 •

edited

Loading