fix(useMediaQuery): add support for safari 13- #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MediaQuery` implementation fix #242
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 749 751 +2
Branches 133 135 +2
=========================================
+ Hits 749 751 +2
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2021
# [7.0.0](v6.1.0...v7.0.0) (2021-08-06) ### Bug Fixes * **useMediaQuery:** add support for safari 13- that has obsolete `useMediaQuery` implementation ([#249](#249)) ([25c8599](25c8599)), closes [#242](#242) ### Code Refactoring * **useKeyboardEvent:** improve the code and change signature ([#248](#248)) ([a0e1b24](a0e1b24)) ### BREAKING CHANGES * **useKeyboardEvent:** hook call signature has changed.
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior, and the steps to reproduce the issue?
As Safari 13- has obsolete MediaQueryList API - it requires some extra checks.
What is the expected behavior?
Shpould Work on safari 13-
How does this PR fix the problem?
Check
addEventListenerandremoveEventListenermethods existence and fallback toaddListenerandremoveListenerrespectively.Checklist