Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles of Font Awesome in react-icons@3.0.1 #158

Closed
dparisotto-starcard opened this issue Jul 30, 2018 · 15 comments
Closed

Styles of Font Awesome in react-icons@3.0.1 #158

dparisotto-starcard opened this issue Jul 30, 2018 · 15 comments

Comments

@dparisotto-starcard
Copy link

Hi, how can i use the regular style of an icon in Font Awesome?

regular
solid

Thank you

@kamijin-fanta
Copy link
Member

It is not included now.
I think it should be added.

@justswim
Copy link

justswim commented Aug 9, 2018

I can't seem to use the regular icons - can you please show an example of how to use the regular, outline (not solid) heart?

@pnicolli
Copy link

@justswim They are not included at this time (if you check here, you can see it only exports brands and solid), but I think they should eventually be added.

Removing support for regular icons is causing issues in the migration from version 2. For example, I had FaCircle and FaCircleO in my app, but in FA5 FaCircleO is gone since it's just the regular version of FaCircle, so I can't migrate that icon at all.

@Nantris
Copy link

Nantris commented Aug 27, 2018

@gorangajic @kamijin-fanta is there a plan to address this? Just started using react-icons and it's incredible, but this stopped me dead in my tracks.

@kamijin-fanta
Copy link
Member

I think the work itself is easy.
Please tell me how to make Solid / Regular coexist. There are options to give some prefix / suffix.

  • option 1
       - FaHeart
       - FaHeartReg or FaHeartR
  • otpion 2
       - FaHeart
       - FaRegHeart or FaRHeart

@justswim
Copy link

I think option 2 is most consistent with the font-awesome documentation (https://fontawesome.com/icons/heart?style=regular) ... FaHeart and FaRHeart makes sense to me.

@Nantris
Copy link

Nantris commented Aug 27, 2018

I like option 1 better personally, but I agree with @justswim. Option 2 would be better for consistency with Font-Awesome's docs.

@moshensky
Copy link

+1 for consistency with font-awesome documentation

@leogiertz
Copy link

The style change bit us and I think that option 2 is better for consistency with the FA docs.

@kamijin-fanta
Copy link
Member

please try yarn add react-icons@next .
FaRegTimesCircle etc. should be available!

@leogiertz
Copy link

@kamijin-fanta Works great for us! Thanks.

@kamijin-fanta
Copy link
Member

fix in react-icons@3.1.0

@flaska
Copy link

flaska commented Dec 31, 2018

fix in react-icons@3.1.0

Thank you so much! :) 👍

@drixie
Copy link

drixie commented Oct 5, 2019

Thanks for the great work.

Could you please add this to the documentation? Took me like 10 mins to find this lol.

@gunar
Copy link

gunar commented Aug 27, 2020

tl;dr

import { FaCopy, FaRegCopy } from 'react-icons/fa';

// Solid
<FaCopy />

// Regular
<FaRegCopy />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants