Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds react to the peer dependencies #237

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@arcanis
Copy link
Contributor

arcanis commented May 28, 2019

The react-icons package requires react (in iconBase.tsx) but doesn't list it in its peer dependencies.

This diff fixes it by adding the missing dependency.

@arcanis

This comment has been minimized.

Copy link
Contributor Author

arcanis commented Jul 2, 2019

Ping @kamijin-fanta? Yarn is going to enforce proper package listing. Without this diff, your users will have to follow workarounds for react-icons to work.

@kamijin-fanta kamijin-fanta merged commit 5c00a28 into react-icons:master Sep 27, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@kamijin-fanta

This comment has been minimized.

Copy link
Member

kamijin-fanta commented Oct 25, 2019

published in react-icons@3.8.0.
thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.