Skip to content

fix(web): prevent player rerender when onError is not wrapped with useCallback #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2025
Merged

fix(web): prevent player rerender when onError is not wrapped with useCallback #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0479377
fix(web): prevent player rerender when onError is not wrapped with us…
saseungmin Jun 22, 2025
70d6afc
chore(changeset): patch version update
saseungmin Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/open-olives-cry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-youtube-bridge": patch
---

fix(web): prevent player rerender when onError is not wrapped with useCallback
5 changes: 3 additions & 2 deletions src/hooks/useYoutubePlayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const useYouTubePlayer = (config: YoutubePlayerConfig) => {
coreRef.current = null;
}, []);

// biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
// biome-ignore lint/correctness/useExhaustiveDependencies: initialize only once
useEffect(() => {
if (!coreRef.current) {
coreRef.current = new YouTubePlayerCore({
Expand All @@ -46,6 +46,7 @@ const useYouTubePlayer = (config: YoutubePlayerConfig) => {
return cleanup;
}, []);

// biome-ignore lint/correctness/useExhaustiveDependencies: update only playerVars
useEffect(() => {
const initialize = async () => {
if (!containerRef.current) {
Expand Down Expand Up @@ -81,7 +82,7 @@ const useYouTubePlayer = (config: YoutubePlayerConfig) => {
};

initialize();
}, [videoId, startTime, endTime, autoplay, controls, loop, muted, playsinline, rel, origin, onError]);
}, [videoId, startTime, endTime, autoplay, controls, loop, muted, playsinline, rel, origin]);

useEffect(() => {
if (isReady && videoId && coreRef.current) {
Expand Down