This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
feat(android): add videoBitrate option for recordAsync #2055
It falls back to default behavior, as if this code was never implemented.…
On Jan 16, 2019, at 10:44 AM, Sibelius Seraphini ***@***.***> wrote: @sibelius approved this pull request. What happens when user does not pass it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2055 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AlQSbczqNFFQN3vwWqMC3GM1GOV9tXDAks5vD1bVgaJpZM4aDelH>.
Andrew Schenk added 3 commits
January 17, 2019 07:35
…targetBitrate in RNCamera. Adds safety rails for proper usage.
n1ru4l pushed a commit that referenced this pull request
Jan 18, 2019
sunil-dev7 added a commit to sunil-dev7/react-native-camera that referenced this pull request
Jun 11, 2021
# [1.9.0](firstname.lastname@example.org...v1.9.0) (2019-01-18) ### Features * **android:** add videoBitrate option for recordAsync ([#2055](react-native-camera/react-native-camera#2055)) [skip release] ([d93a6c7](react-native-camera/react-native-camera@d93a6c7)) * allow camera scene when audio permissions are denied ([#2048](react-native-camera/react-native-camera#2048)), Fixes [#2047](react-native-camera/react-native-camera#2047), Fixes [#2051](react-native-camera/react-native-camera#2051) ([22533ed](react-native-camera/react-native-camera@22533ed))
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.