feat(android): add videoBitrate option for recordAsync #2055
Conversation
…te takes an integer value (e.g. 1000*1000*5 aka 5Mbps).
What happens when user does not pass it? |
It falls back to default behavior, as if this code was never implemented.
… On Jan 16, 2019, at 10:44 AM, Sibelius Seraphini ***@***.***> wrote:
@sibelius approved this pull request.
What happens when user does not pass it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#2055 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AlQSbczqNFFQN3vwWqMC3GM1GOV9tXDAks5vD1bVgaJpZM4aDelH>.
|
@andrewschenk-linx Could you please add types and documentation |
…targetBitrate in RNCamera. Adds safety rails for proper usage.
Added documentation and types. |
After thinking about it a bit I think we can name it Can you please rename it? I will merge it aftwerwards! |
d93a6c7
into
react-native-camera:master
1 check passed
1 check passed
The release is available on: Your semantic-release bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
While VideoQuality can be set, this option does not give developers anyway to fine-tune the resulting file size of a recorded video. 720p recording will use a 12 Mbps bitrate on a Galaxy S8+, even though 720p should be closer to 5 Mbps.
Introducing a new optional recording option helps to solve this problem.
targetBitrate takes an integer value (e.g. 1000 x 1000 x 5 aka 5Mbps).
Example of calling it from React Native