Project directory missing from run instructions

[patrickkempff]

Environment

info Fetching system and libraries information...
System:
    OS: macOS 10.14.5
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 188.53 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 12.1.0 - ~/.nvm/versions/node/v12.1.0/bin/node
    Yarn: 1.15.2 - ~/.yarn/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v12.1.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
    Android SDK:
      API Levels: 21, 22, 23, 24, 25, 26, 27, 28
      Build Tools: 26.0.3, 27.0.3, 28.0.2, 28.0.3
      System Images: android-21 | Intel x86 Atom_64, android-21 | Google APIs Intel x86 Atom, android-21 | Google APIs Intel x86 Atom_64, android-22 | Intel x86 Atom_64, android-22 | Google APIs ARM EABI v7a, android-22 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom_64, android-23 | Intel x86 Atom_64, android-23 | Google APIs ARM EABI v7a, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-24 | Intel x86 Atom_64, android-24 | Google APIs Intel x86 Atom, android-24 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-25 | Intel x86 Atom_64, android-25 | Google APIs Intel x86 Atom, android-25 | Google APIs Intel x86 Atom_64, android-25 | Google Play Intel x86 Atom, android-26 | Intel x86 Atom_64, android-26 | Google APIs Intel x86 Atom, android-26 | Google APIs Intel x86 Atom_64, android-26 | Google Play Intel x86 Atom, android-27 | Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64
      Android NDK: 19.2.5345600
  IDEs:
    Android Studio: 3.4 AI-183.5429.30.34.5452501
    Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6 
    react-native: 0.60.0 => 0.60.0

Description

I initialised a new project called "example" inside of the sailor folder. The run instructions show the following path:

cd /Users/patrickkempff/Development/projects/sailor && react-native run-ios

instead of

cd /Users/patrickkempff/Development/projects/sailor/example && react-native run-ios

same goes for the android path. See the screenshot below

Reproducible Demo

run npx react-native example and see that the "example" dir is missing from the run instructions.

[thymikee]

Yea, looks like we pass wrong directory to the printRunInstructions:

cli/packages/cli/src/commands/init/init.js

Lines 212 to 221 in 212587f

	const directoryName = getProjectDirectory({
	projectName,
	directory: options.directory || projectName,
	});
	const directoryExists = doesDirectoryExist(directoryName);
	try {
	await createProject(projectName, directoryName, version, options);
	printRunInstructions(rootFolder, projectName);

We likely need to join rootFolder with directoryName, at least that would be my guess.

Anybody willing to fix it? :)

[Taym95]

I would like to take this issue!

[thymikee]

@Taym95 sure, I marked this issue as taken, it's yours now

[patrickkempff]

awesome @Taym95 👍