From dec89abcef8ffcd73a2dd385dff10d548d31939f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Sat, 22 Feb 2020 11:51:49 +0100 Subject: [PATCH] feat: remove node-notifier to reduce install size --- packages/cli/package.json | 2 -- packages/cli/src/commands/server/messageSocket.ts | 13 +++++-------- yarn.lock | 7 ------- 3 files changed, 5 insertions(+), 17 deletions(-) diff --git a/packages/cli/package.json b/packages/cli/package.json index e70027fee..1142eb32f 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -54,7 +54,6 @@ "minimist": "^1.2.0", "mkdirp": "^0.5.1", "morgan": "^1.9.0", - "node-notifier": "^5.2.1", "open": "^6.2.0", "ora": "^3.4.0", "plist": "^3.0.0", @@ -80,7 +79,6 @@ "@types/minimist": "^1.2.0", "@types/mkdirp": "^0.5.2", "@types/morgan": "^1.7.37", - "@types/node-notifier": "^5.4.0", "@types/pretty-format": "^24.3.0", "@types/semver": "^6.0.2", "@types/wcwidth": "^1.0.0", diff --git a/packages/cli/src/commands/server/messageSocket.ts b/packages/cli/src/commands/server/messageSocket.ts index c3bd6603b..e458daf78 100644 --- a/packages/cli/src/commands/server/messageSocket.ts +++ b/packages/cli/src/commands/server/messageSocket.ts @@ -7,7 +7,6 @@ import url from 'url'; import {Server as WebSocketServer} from 'ws'; -import notifier from 'node-notifier'; import {logger} from '@react-native-community/cli-tools'; import {Server as HttpServer} from 'http'; import {Server as HttpsServer} from 'https'; @@ -100,13 +99,11 @@ function attachToServer(server: Server, path: string) { params: message.params, }; if (clients.size === 0) { - notifier.notify({ - title: 'React Native: No apps connected', - message: - `Sending '${message.method}' to all React Native apps ` + - 'failed. Make sure your app is running in the simulator ' + - 'or on a phone connected via USB.', - }); + logger.warn( + `No apps connected. Sending "${ + message.method + }" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB.`, + ); } for (const [otherId, otherWs] of clients) { if (otherId !== broadcasterId) { diff --git a/yarn.lock b/yarn.lock index 99b80152f..ed9c9b12c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2897,13 +2897,6 @@ dependencies: "@types/node" "*" -"@types/node-notifier@^5.4.0": - version "5.4.0" - resolved "https://registry.yarnpkg.com/@types/node-notifier/-/node-notifier-5.4.0.tgz#4e66c85eb41cce8387b4cd9c6c67852be41a99db" - integrity sha512-M1XvCG6Rwej6+W0+kWultE46YS7erOy+W7suRmXtKwLGT3ytj6YEe9lqo47nRfL1xILzg9xJpKeNczIsWR8ymw== - dependencies: - "@types/node" "*" - "@types/node@*": version "12.0.0" resolved "https://registry.yarnpkg.com/@types/node/-/node-12.0.0.tgz#d11813b9c0ff8aaca29f04cbc12817f4c7d656e5"