From 3153034a706ed29b03d79f18da36d7047940f795 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Sun, 23 Feb 2020 22:17:06 +0100 Subject: [PATCH] chore: remove morgan --- packages/cli/package.json | 2 -- packages/cli/src/commands/server/runServer.ts | 14 ----------- yarn.lock | 23 ------------------- 3 files changed, 39 deletions(-) diff --git a/packages/cli/package.json b/packages/cli/package.json index a3f03a053..544b70616 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -53,7 +53,6 @@ "metro-react-native-babel-transformer": "^0.58.0", "minimist": "^1.2.0", "mkdirp": "^0.5.1", - "morgan": "^1.9.0", "open": "^6.2.0", "ora": "^3.4.0", "plist": "^3.0.0", @@ -78,7 +77,6 @@ "@types/hapi__joi": "^15.0.4", "@types/minimist": "^1.2.0", "@types/mkdirp": "^0.5.2", - "@types/morgan": "^1.7.37", "@types/pretty-format": "^24.3.0", "@types/semver": "^6.0.2", "@types/wcwidth": "^1.0.0", diff --git a/packages/cli/src/commands/server/runServer.ts b/packages/cli/src/commands/server/runServer.ts index a5cbbf930..d15b3ab02 100644 --- a/packages/cli/src/commands/server/runServer.ts +++ b/packages/cli/src/commands/server/runServer.ts @@ -9,10 +9,8 @@ import Metro from 'metro'; // @ts-ignore untyped metro import {Terminal} from 'metro-core'; -import morgan from 'morgan'; import http from 'http'; import path from 'path'; -import {logger} from '@react-native-community/cli-tools'; import {Config} from '@react-native-community/cli-types'; import messageSocket from './messageSocket'; import eventsSocketModule from './eventsSocket'; @@ -81,18 +79,6 @@ async function runServer(_argv: Array, ctx: Config, args: Args) { watchFolders: metroConfig.watchFolders, }); - middlewareManager.getConnectInstance().use( - // @ts-ignore morgan and connect types mismatch - morgan( - 'combined', - !logger.isVerbose() - ? { - skip: (_req, res) => res.statusCode < 400, - } - : undefined, - ), - ); - metroConfig.watchFolders.forEach( middlewareManager.serveStatic.bind(middlewareManager), ); diff --git a/yarn.lock b/yarn.lock index 9e5c0fd44..1fe80120c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2876,13 +2876,6 @@ dependencies: "@types/node" "*" -"@types/morgan@^1.7.37": - version "1.7.37" - resolved "https://registry.yarnpkg.com/@types/morgan/-/morgan-1.7.37.tgz#ebdd0b0f0276073f85283bf4f03c7c54284874df" - integrity sha512-tIdEA10BcHcOumMmUiiYdw8lhiVVq62r0ghih5Xpp4WETkfsMiTUZL4w9jCI502BBOrKhFrAOGml9IeELvVaBA== - dependencies: - "@types/express" "*" - "@types/node-fetch@^2.3.3": version "2.3.3" resolved "https://registry.yarnpkg.com/@types/node-fetch/-/node-fetch-2.3.3.tgz#eb9c2a0ce8e9424ebe0c0cbe6f1e8ea7576c1310" @@ -3579,12 +3572,6 @@ base@^0.11.1: mixin-deep "^1.2.0" pascalcase "^0.1.1" -basic-auth@~2.0.0: - version "2.0.1" - resolved "https://registry.yarnpkg.com/basic-auth/-/basic-auth-2.0.1.tgz#b998279bf47ce38344b4f3cf916d4679bbf51e3a" - dependencies: - safe-buffer "5.1.2" - bcrypt-pbkdf@^1.0.0: version "1.0.2" resolved "https://registry.yarnpkg.com/bcrypt-pbkdf/-/bcrypt-pbkdf-1.0.2.tgz#a4301d389b6a43f9b67ff3ca11a3f6637e360e9e" @@ -8529,16 +8516,6 @@ modify-values@^1.0.0: resolved "https://registry.yarnpkg.com/modify-values/-/modify-values-1.0.1.tgz#b3939fa605546474e3e3e3c63d64bd43b4ee6022" integrity sha512-xV2bxeN6F7oYjZWTe/YPAy6MN2M+sL4u/Rlm2AHCIVGfo2p1yGmBHQ6vHehl4bRTZBdHu3TSkWdYgkwpYzAGSw== -morgan@^1.9.0: - version "1.9.1" - resolved "https://registry.yarnpkg.com/morgan/-/morgan-1.9.1.tgz#0a8d16734a1d9afbc824b99df87e738e58e2da59" - dependencies: - basic-auth "~2.0.0" - debug "2.6.9" - depd "~1.1.2" - on-finished "~2.3.0" - on-headers "~1.0.1" - move-concurrently@^1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/move-concurrently/-/move-concurrently-1.0.1.tgz#be2c005fda32e0b29af1f05d7c4b33214c701f92"