From b50b6b7888e3af1ed300934b5bce165c3ea02a61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Wed, 27 Jul 2022 11:44:15 +0200 Subject: [PATCH] chore: remove minimist and unused lodash deps --- packages/cli-platform-android/package.json | 1 - .../src/config/__fixtures__/files/package.json | 1 - packages/cli-platform-ios/package.json | 1 - packages/cli/package.json | 4 ---- packages/cli/src/commands/init/init.ts | 12 +++--------- 5 files changed, 3 insertions(+), 16 deletions(-) diff --git a/packages/cli-platform-android/package.json b/packages/cli-platform-android/package.json index e601947f2..529878c45 100644 --- a/packages/cli-platform-android/package.json +++ b/packages/cli-platform-android/package.json @@ -13,7 +13,6 @@ "fs-extra": "^8.1.0", "glob": "^7.1.3", "jetifier": "^1.6.2", - "lodash": "^4.17.15", "logkitty": "^0.7.1", "slash": "^3.0.0" }, diff --git a/packages/cli-platform-android/src/config/__fixtures__/files/package.json b/packages/cli-platform-android/src/config/__fixtures__/files/package.json index 5c197853c..4c8ead1a9 100644 --- a/packages/cli-platform-android/src/config/__fixtures__/files/package.json +++ b/packages/cli-platform-android/src/config/__fixtures__/files/package.json @@ -50,7 +50,6 @@ "react-native": ">=0.4.0 || 0.5.0-rc1 || 0.6.0-rc || 0.7.0-rc || 0.7.0-rc.2 || 0.8.0-rc || 0.8.0-rc.2 || 0.9.0-rc || 0.10.0-rc || 0.11.0-rc || 0.12.0-rc || 0.13.0-rc || 0.14.0-rc || 0.15.0-rc || 0.16.0-rc" }, "dependencies": { - "lodash": "^4.17.10", "yargs": "^3.30.0", "rnpm-plugin-test": "*" }, diff --git a/packages/cli-platform-ios/package.json b/packages/cli-platform-ios/package.json index 45bdedd27..8ac574a2d 100644 --- a/packages/cli-platform-ios/package.json +++ b/packages/cli-platform-ios/package.json @@ -12,7 +12,6 @@ "execa": "^1.0.0", "glob": "^7.1.3", "js-yaml": "^3.13.1", - "lodash": "^4.17.15", "ora": "^5.4.1", "plist": "^3.0.2" }, diff --git a/packages/cli/package.json b/packages/cli/package.json index 7b43ec6cc..61a5032b3 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -39,8 +39,6 @@ "find-up": "^4.1.0", "fs-extra": "^8.1.0", "graceful-fs": "^4.1.3", - "lodash": "^4.17.15", - "minimist": "^1.2.0", "prompts": "^2.4.0", "semver": "^6.3.0" }, @@ -51,8 +49,6 @@ "@types/fs-extra": "^8.1.0", "@types/graceful-fs": "^4.1.3", "@types/hapi__joi": "^17.1.6", - "@types/lodash": "^4.14.149", - "@types/minimist": "^1.2.0", "@types/prompts": "^2.0.9", "@types/semver": "^6.0.2", "deepmerge": "^3.2.0", diff --git a/packages/cli/src/commands/init/init.ts b/packages/cli/src/commands/init/init.ts index df063e171..82aff8c6d 100644 --- a/packages/cli/src/commands/init/init.ts +++ b/packages/cli/src/commands/init/init.ts @@ -1,7 +1,6 @@ import os from 'os'; import path from 'path'; import fs from 'fs-extra'; -import minimist from 'minimist'; import {validateProjectName} from './validate'; import DirectoryAlreadyExistsError from './errors/DirectoryAlreadyExistsError'; import printRunInstructions from './printRunInstructions'; @@ -31,6 +30,7 @@ type Options = { displayName?: string; title?: string; skipInstall?: boolean; + version?: string; }; interface TemplateOptions { @@ -196,16 +196,10 @@ export default (async function initialize( [projectName]: Array, options: Options, ) { - const root = process.cwd(); - validateProjectName(projectName); - /** - * Commander is stripping `version` from options automatically. - * We have to use `minimist` to take that directly from `process.argv` - */ - const version: string = minimist(process.argv).version || DEFAULT_VERSION; - + const root = process.cwd(); + const version = options.version || DEFAULT_VERSION; const directoryName = path.relative(root, options.directory || projectName); try {