From 2ee4f8bbd288cc95a341a5daa9affbd911e4bd9f Mon Sep 17 00:00:00 2001 From: Lorenzo Sciandra Date: Fri, 14 Oct 2022 12:35:56 +0100 Subject: [PATCH 1/3] change the wording --- packages/cli-tools/src/releaseChecker/printNewRelease.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli-tools/src/releaseChecker/printNewRelease.ts b/packages/cli-tools/src/releaseChecker/printNewRelease.ts index 1243b08d0..111768d0e 100644 --- a/packages/cli-tools/src/releaseChecker/printNewRelease.ts +++ b/packages/cli-tools/src/releaseChecker/printNewRelease.ts @@ -16,7 +16,7 @@ export default function printNewRelease( ); logger.info(`Changelog: ${chalk.dim.underline(latestRelease.changelogUrl)}`); logger.info(`Diff: ${chalk.dim.underline(latestRelease.diffUrl)}`); - logger.info(`To upgrade, run "${chalk.bold('react-native upgrade')}".`); + logger.info(`For more info, check out "${chalk.dim.underline('https://reactnative.dev/docs/upgrading')}".`); cacheManager.set(name, 'lastChecked', new Date().toISOString()); } From 0599c9eebc7ac32104f690ddc480a1205d2c3baf Mon Sep 17 00:00:00 2001 From: Lorenzo Sciandra Date: Fri, 14 Oct 2022 12:50:15 +0100 Subject: [PATCH 2/3] add small bit of logic to avoid checking for nightlies and such --- .../cli-tools/src/releaseChecker/getLatestRelease.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/cli-tools/src/releaseChecker/getLatestRelease.ts b/packages/cli-tools/src/releaseChecker/getLatestRelease.ts index b1f27c879..53b12a027 100644 --- a/packages/cli-tools/src/releaseChecker/getLatestRelease.ts +++ b/packages/cli-tools/src/releaseChecker/getLatestRelease.ts @@ -24,6 +24,15 @@ export default async function getLatestRelease( try { logger.debug(`Current version: ${currentVersion}`); + // if the version is a 1000.0.0 version or 0.0.0, we want to bail + // since they are nightlies or unreleased versions + if ( + currentVersion.includes('1000.0.0') || + currentVersion.includes('0.0.0') + ) { + return; + } + const cachedLatest = cacheManager.get(name, 'latestVersion'); if (cachedLatest) { From 2e2e886dc824fc3bd3670b24b04e8a33e115ceca Mon Sep 17 00:00:00 2001 From: Lorenzo Sciandra Date: Fri, 14 Oct 2022 12:53:06 +0100 Subject: [PATCH 3/3] lint --- packages/cli-tools/src/releaseChecker/printNewRelease.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/cli-tools/src/releaseChecker/printNewRelease.ts b/packages/cli-tools/src/releaseChecker/printNewRelease.ts index 111768d0e..bd237d7a2 100644 --- a/packages/cli-tools/src/releaseChecker/printNewRelease.ts +++ b/packages/cli-tools/src/releaseChecker/printNewRelease.ts @@ -16,7 +16,11 @@ export default function printNewRelease( ); logger.info(`Changelog: ${chalk.dim.underline(latestRelease.changelogUrl)}`); logger.info(`Diff: ${chalk.dim.underline(latestRelease.diffUrl)}`); - logger.info(`For more info, check out "${chalk.dim.underline('https://reactnative.dev/docs/upgrading')}".`); + logger.info( + `For more info, check out "${chalk.dim.underline( + 'https://reactnative.dev/docs/upgrading', + )}".`, + ); cacheManager.set(name, 'lastChecked', new Date().toISOString()); }