Skip to content

feat: morgan - skip successful requests if 'verbose' is set to false #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2019
Merged

feat: morgan - skip successful requests if 'verbose' is set to false #291

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
829cfde
feat: morgan - skip successful requests if 'verbose' is set to false
vancehu Apr 4, 2019
89e6caa
Merge remote-tracking branch 'upstream/master'
vancehu Apr 9, 2019
0415a79
fix: use isVerbose instead of args.verbose in morgan
vancehu Apr 9, 2019
8a44d16
Update runServer.js
thymikee Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/cli/src/commands/server/runServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,14 @@
*/

import Metro from 'metro';

import {Terminal} from 'metro-core';

import morgan from 'morgan';
import path from 'path';
import {logger} from '@react-native-community/cli-tools';
import type {ConfigT} from '../../tools/config/types.flow';
import messageSocket from './messageSocket';
import webSocketProxy from './webSocketProxy';
import MiddlewareManager from './middleware/MiddlewareManager';

import loadMetroConfig from '../../tools/loadMetroConfig';

export type Args = {|
Expand Down Expand Up @@ -62,7 +60,14 @@ async function runServer(argv: Array<string>, ctx: ConfigT, args: Args) {
watchFolders: metroConfig.watchFolders,
});

middlewareManager.getConnectInstance().use(morgan('combined'));
middlewareManager.getConnectInstance().use(
morgan(
'combined',
!logger.isVerbose() && {
skip: (req, res) => res.statusCode < 400,
},
),
);

metroConfig.watchFolders.forEach(
middlewareManager.serveStatic.bind(middlewareManager),
Expand Down