Skip to content

fix: shorter and correct paths in init run instructions #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2019
Merged

fix: shorter and correct paths in init run instructions #533

merged 2 commits into from
Jul 16, 2019

Conversation

@Taym95
Copy link
Contributor

@Taym95 Taym95 commented Jul 15, 2019

Fix #524

@thymikee
Copy link
Member

thymikee commented Jul 15, 2019

Can we make all the paths inside printRunInstructions.js output relative?

@Taym95
Copy link
Contributor Author

Taym95 commented Jul 16, 2019

Yes sure!

thymikee
thymikee approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thymikee thymikee changed the title Add projectName to iosProjectDir fix: shorter and correct paths in init run instructions Jul 16, 2019
@thymikee thymikee merged commit 062f02b into react-native-community:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

@grabbou grabbou Awaiting requested review from grabbou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI completion message for iOS requires an extra path element

2 participants

@Taym95 @thymikee