From f57cb55e35204de3ebbe2f79f7902cf76e6646d8 Mon Sep 17 00:00:00 2001 From: Jay Meistrich Date: Tue, 3 Sep 2019 16:39:15 +0200 Subject: [PATCH 1/2] fix semver check was breaking for non-semver versions --- packages/cli/src/commands/doctor/checkInstallation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/commands/doctor/checkInstallation.js b/packages/cli/src/commands/doctor/checkInstallation.js index 13ef4237a..597fa7365 100644 --- a/packages/cli/src/commands/doctor/checkInstallation.js +++ b/packages/cli/src/commands/doctor/checkInstallation.js @@ -17,6 +17,6 @@ const isSoftwareInstalled = async command => { }; const doesSoftwareNeedToBeFixed = ({version, versionRange}) => - version === 'Not Found' || !semver.satisfies(version, versionRange); + version === 'Not Found' || !semver.satisfies(semver.coerce(version), versionRange); export {PACKAGE_MANAGERS, isSoftwareInstalled, doesSoftwareNeedToBeFixed}; From d60b8bca5aadc6b9cf03074f37fb40099292dcd4 Mon Sep 17 00:00:00 2001 From: Jay Meistrich Date: Tue, 3 Sep 2019 17:05:50 +0200 Subject: [PATCH 2/2] fix prettier error with a line being too long --- packages/cli/src/commands/doctor/checkInstallation.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/commands/doctor/checkInstallation.js b/packages/cli/src/commands/doctor/checkInstallation.js index 597fa7365..1a42a7f79 100644 --- a/packages/cli/src/commands/doctor/checkInstallation.js +++ b/packages/cli/src/commands/doctor/checkInstallation.js @@ -17,6 +17,7 @@ const isSoftwareInstalled = async command => { }; const doesSoftwareNeedToBeFixed = ({version, versionRange}) => - version === 'Not Found' || !semver.satisfies(semver.coerce(version), versionRange); + version === 'Not Found' || + !semver.satisfies(semver.coerce(version), versionRange); export {PACKAGE_MANAGERS, isSoftwareInstalled, doesSoftwareNeedToBeFixed};