From fe4a2a8b0fe9c6fdc3bd983596708563ad3c1a21 Mon Sep 17 00:00:00 2001 From: quadriphobs1 Date: Tue, 10 Sep 2019 12:55:24 +0100 Subject: [PATCH 1/4] chore: converted install command to typescript --- .../cli/src/commands/install/{install.js => install.ts} | 9 +++++---- .../src/commands/install/{uninstall.js => uninstall.ts} | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) rename packages/cli/src/commands/install/{install.js => install.ts} (77%) rename packages/cli/src/commands/install/{uninstall.js => uninstall.ts} (72%) diff --git a/packages/cli/src/commands/install/install.js b/packages/cli/src/commands/install/install.ts similarity index 77% rename from packages/cli/src/commands/install/install.js rename to packages/cli/src/commands/install/install.ts index a15072ed1..bdb8d8bc8 100644 --- a/packages/cli/src/commands/install/install.js +++ b/packages/cli/src/commands/install/install.ts @@ -4,16 +4,17 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @flow */ - -import type {ConfigT} from 'types'; +/* eslint-disable import/namespace, import/default */ import {logger} from '@react-native-community/cli-tools'; +// @ts-ignore FIXME after converting tools/packageManager import * as PackageManager from '../../tools/packageManager'; +// @ts-ignore FIXME after converting link/link import link from '../link/link'; +// @ts-ignore FIXME after converting tools/config import loadConfig from '../../tools/config'; -async function install(args: Array, ctx: ConfigT) { +async function install(args: Array) { const name = args[0]; logger.info(`Installing "${name}"...`); diff --git a/packages/cli/src/commands/install/uninstall.js b/packages/cli/src/commands/install/uninstall.ts similarity index 72% rename from packages/cli/src/commands/install/uninstall.js rename to packages/cli/src/commands/install/uninstall.ts index be22269c9..fa005264d 100644 --- a/packages/cli/src/commands/install/uninstall.js +++ b/packages/cli/src/commands/install/uninstall.ts @@ -4,15 +4,16 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @flow */ - -import type {ConfigT} from 'types'; +/* eslint-disable import/namespace, import/default */ +import {Config} from '@react-native-community/cli-types'; import {logger} from '@react-native-community/cli-tools'; +// @ts-ignore FIXME after converting tools/packageManager import * as PackageManager from '../../tools/packageManager'; +// @ts-ignore FIXME after converting link/unlink import unlink from '../link/unlink'; -async function uninstall(args: Array, ctx: ConfigT) { +async function uninstall(args: Array, ctx: Config) { const name = args[0]; logger.info(`Unlinking "${name}"...`); From 0f16f94b8f8614820ce6f4335888ceefce1104b6 Mon Sep 17 00:00:00 2001 From: quadriphobs1 Date: Tue, 10 Sep 2019 13:06:49 +0100 Subject: [PATCH 2/4] fix eslints --- packages/cli/src/commands/index.ts | 6 ++---- packages/cli/src/commands/install/install.ts | 2 +- packages/cli/src/commands/install/uninstall.ts | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/cli/src/commands/index.ts b/packages/cli/src/commands/index.ts index c9b07a6a6..3d1c5258a 100644 --- a/packages/cli/src/commands/index.ts +++ b/packages/cli/src/commands/index.ts @@ -10,10 +10,8 @@ import ramBundle from './bundle/ramBundle'; import link from './link/link'; // eslint-disable-line import/namespace, import/default // @ts-ignore - JS file import unlink from './link/unlink'; // eslint-disable-line import/namespace, import/default -// @ts-ignore - JS file -import install from './install/install'; // eslint-disable-line import/namespace, import/default -// @ts-ignore - JS file -import uninstall from './install/uninstall'; // eslint-disable-line import/namespace, import/default +import install from './install/install'; +import uninstall from './install/uninstall'; import upgrade from './upgrade/upgrade'; import info from './info/info'; // @ts-ignore - JS file diff --git a/packages/cli/src/commands/install/install.ts b/packages/cli/src/commands/install/install.ts index bdb8d8bc8..fcc9890f7 100644 --- a/packages/cli/src/commands/install/install.ts +++ b/packages/cli/src/commands/install/install.ts @@ -14,7 +14,7 @@ import link from '../link/link'; // @ts-ignore FIXME after converting tools/config import loadConfig from '../../tools/config'; -async function install(args: Array) { +async function install(args: Array): Promise { const name = args[0]; logger.info(`Installing "${name}"...`); diff --git a/packages/cli/src/commands/install/uninstall.ts b/packages/cli/src/commands/install/uninstall.ts index fa005264d..1e893a163 100644 --- a/packages/cli/src/commands/install/uninstall.ts +++ b/packages/cli/src/commands/install/uninstall.ts @@ -13,7 +13,7 @@ import * as PackageManager from '../../tools/packageManager'; // @ts-ignore FIXME after converting link/unlink import unlink from '../link/unlink'; -async function uninstall(args: Array, ctx: Config) { +async function uninstall(args: Array, ctx: Config): Promise { const name = args[0]; logger.info(`Unlinking "${name}"...`); From 913a82282968f3b7fab07d859730d6d102c21478 Mon Sep 17 00:00:00 2001 From: quadriphobs1 Date: Tue, 10 Sep 2019 15:29:42 +0100 Subject: [PATCH 3/4] remove eslint silent comment --- packages/cli/src/commands/install/install.ts | 2 -- packages/cli/src/commands/install/uninstall.ts | 2 -- 2 files changed, 4 deletions(-) diff --git a/packages/cli/src/commands/install/install.ts b/packages/cli/src/commands/install/install.ts index fcc9890f7..e7765eda5 100644 --- a/packages/cli/src/commands/install/install.ts +++ b/packages/cli/src/commands/install/install.ts @@ -5,9 +5,7 @@ * LICENSE file in the root directory of this source tree. * */ -/* eslint-disable import/namespace, import/default */ import {logger} from '@react-native-community/cli-tools'; -// @ts-ignore FIXME after converting tools/packageManager import * as PackageManager from '../../tools/packageManager'; // @ts-ignore FIXME after converting link/link import link from '../link/link'; diff --git a/packages/cli/src/commands/install/uninstall.ts b/packages/cli/src/commands/install/uninstall.ts index 1e893a163..d162f144b 100644 --- a/packages/cli/src/commands/install/uninstall.ts +++ b/packages/cli/src/commands/install/uninstall.ts @@ -5,10 +5,8 @@ * LICENSE file in the root directory of this source tree. * */ -/* eslint-disable import/namespace, import/default */ import {Config} from '@react-native-community/cli-types'; import {logger} from '@react-native-community/cli-tools'; -// @ts-ignore FIXME after converting tools/packageManager import * as PackageManager from '../../tools/packageManager'; // @ts-ignore FIXME after converting link/unlink import unlink from '../link/unlink'; From 3f12d970787bd4af0f03ce5060045a1cd06fc4c3 Mon Sep 17 00:00:00 2001 From: quadriphobs1 Date: Tue, 10 Sep 2019 16:10:21 +0100 Subject: [PATCH 4/4] disable eslint for concerned line --- packages/cli/src/commands/install/install.ts | 4 ++-- packages/cli/src/commands/install/uninstall.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/cli/src/commands/install/install.ts b/packages/cli/src/commands/install/install.ts index e7765eda5..3405af990 100644 --- a/packages/cli/src/commands/install/install.ts +++ b/packages/cli/src/commands/install/install.ts @@ -8,9 +8,9 @@ import {logger} from '@react-native-community/cli-tools'; import * as PackageManager from '../../tools/packageManager'; // @ts-ignore FIXME after converting link/link -import link from '../link/link'; +import link from '../link/link'; // eslint-disable-line import/namespace, import/default // @ts-ignore FIXME after converting tools/config -import loadConfig from '../../tools/config'; +import loadConfig from '../../tools/config'; // eslint-disable-line import/namespace, import/default async function install(args: Array): Promise { const name = args[0]; diff --git a/packages/cli/src/commands/install/uninstall.ts b/packages/cli/src/commands/install/uninstall.ts index d162f144b..61da179ef 100644 --- a/packages/cli/src/commands/install/uninstall.ts +++ b/packages/cli/src/commands/install/uninstall.ts @@ -9,7 +9,7 @@ import {Config} from '@react-native-community/cli-types'; import {logger} from '@react-native-community/cli-tools'; import * as PackageManager from '../../tools/packageManager'; // @ts-ignore FIXME after converting link/unlink -import unlink from '../link/unlink'; +import unlink from '../link/unlink'; // eslint-disable-line import/namespace, import/default async function uninstall(args: Array, ctx: Config): Promise { const name = args[0];