From 6593556710c57e71ad32e6daa1a408276e90727b Mon Sep 17 00:00:00 2001 From: Jesse Katsumata Date: Mon, 16 Sep 2019 15:49:33 +0900 Subject: [PATCH 1/2] chore: convert walk to ts --- packages/cli/src/tools/{walk.js => walk.ts} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename packages/cli/src/tools/{walk.js => walk.ts} (78%) diff --git a/packages/cli/src/tools/walk.js b/packages/cli/src/tools/walk.ts similarity index 78% rename from packages/cli/src/tools/walk.js rename to packages/cli/src/tools/walk.ts index fb0a81eba..7043c91b2 100644 --- a/packages/cli/src/tools/walk.js +++ b/packages/cli/src/tools/walk.ts @@ -4,13 +4,12 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @flow */ import fs from 'fs'; import path from 'path'; -function walk(current: string) { +function walk(current: string): string[] { if (!fs.lstatSync(current).isDirectory()) { return [current]; } @@ -18,7 +17,8 @@ function walk(current: string) { const files = fs .readdirSync(current) .map(child => walk(path.join(current, child))); - return [].concat.apply([current], files); + const result: string[] = []; + return result.concat.apply([current], files); } export default walk; From 0edac93166da5f15a03cecdd61581953df959074 Mon Sep 17 00:00:00 2001 From: Jesse Katsumata Date: Mon, 16 Sep 2019 15:50:53 +0900 Subject: [PATCH 2/2] chore: remove ts-ignore comments --- packages/cli/src/commands/init/editTemplate.ts | 1 - packages/cli/src/tools/copyFiles.ts | 1 - .../cli/src/tools/generator/copyProjectTemplateAndReplace.ts | 1 - 3 files changed, 3 deletions(-) diff --git a/packages/cli/src/commands/init/editTemplate.ts b/packages/cli/src/commands/init/editTemplate.ts index 22029e7f9..3d9db25fc 100644 --- a/packages/cli/src/commands/init/editTemplate.ts +++ b/packages/cli/src/commands/init/editTemplate.ts @@ -1,7 +1,6 @@ import fs from 'fs'; import path from 'path'; import {logger} from '@react-native-community/cli-tools'; -// @ts-ignore FIXME after converting walk to typescript import walk from '../../tools/walk'; interface PlaceholderConfig { diff --git a/packages/cli/src/tools/copyFiles.ts b/packages/cli/src/tools/copyFiles.ts index 40ef70d3a..fcbe66523 100644 --- a/packages/cli/src/tools/copyFiles.ts +++ b/packages/cli/src/tools/copyFiles.ts @@ -7,7 +7,6 @@ import fs from 'fs'; import path from 'path'; -// @ts-ignore FIXME after converting walk to typescript import walk from './walk'; type Options = { diff --git a/packages/cli/src/tools/generator/copyProjectTemplateAndReplace.ts b/packages/cli/src/tools/generator/copyProjectTemplateAndReplace.ts index 7624262cf..c8e089eed 100644 --- a/packages/cli/src/tools/generator/copyProjectTemplateAndReplace.ts +++ b/packages/cli/src/tools/generator/copyProjectTemplateAndReplace.ts @@ -11,7 +11,6 @@ import chalk from 'chalk'; import path from 'path'; import copyAndReplace from '../copyAndReplace'; import promptInitializer from './promptSync'; -// @ts-ignore FIXME: walk should be ts import walk from '../walk'; import {logger} from '@react-native-community/cli-tools';