From 23e5b8baa741288cb51848eb1f76ac433945bd93 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 13 Feb 2020 15:34:55 +0530 Subject: [PATCH 1/2] chore: migrate to leven --- packages/cli/package.json | 2 +- packages/cli/src/index.ts | 10 +++++----- yarn.lock | 10 +++++----- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/cli/package.json b/packages/cli/package.json index 2760990b9..788c068a6 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -37,7 +37,6 @@ "connect": "^3.6.5", "cosmiconfig": "^5.1.0", "deepmerge": "^3.2.0", - "didyoumean": "^1.2.1", "envinfo": "^7.1.0", "errorhandler": "^1.5.0", "execa": "^1.0.0", @@ -46,6 +45,7 @@ "glob": "^7.1.1", "graceful-fs": "^4.1.3", "inquirer": "^3.0.6", + "leven": "^3.1.0", "lodash": "^4.17.5", "metro": "^0.58.0", "metro-config": "^0.58.0", diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts index 751fe4e2a..d378c6cec 100644 --- a/packages/cli/src/index.ts +++ b/packages/cli/src/index.ts @@ -1,7 +1,7 @@ import chalk from 'chalk'; import childProcess from 'child_process'; import commander from 'commander'; -import didYouMean from 'didyoumean'; +import leven from 'leven'; import path from 'path'; import {Command, Config} from '@react-native-community/cli-types'; @@ -85,10 +85,10 @@ function printHelpInformation( } function printUnknownCommand(cmdName: string) { - const suggestion = didYouMean( - cmdName, - commander.commands.map(cmd => cmd._name), - ); + const availableCommands = commander.commands.map(cmd => cmd._name); + const suggestion = availableCommands.find(cmd => { + return leven(cmd, cmdName) < 3; + }); let errorMsg = `Unrecognized command "${chalk.bold(cmdName)}".`; if (suggestion) { errorMsg += ` Did you mean "${suggestion}"?`; diff --git a/yarn.lock b/yarn.lock index e495e91df..c701bf2e4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4925,11 +4925,6 @@ dezalgo@^1.0.0: asap "^2.0.0" wrappy "1" -didyoumean@^1.2.1: - version "1.2.1" - resolved "https://registry.yarnpkg.com/didyoumean/-/didyoumean-1.2.1.tgz#e92edfdada6537d484d73c0172fd1eba0c4976ff" - integrity sha1-6S7f2tplN9SE1zwBcv0eugxJdv8= - diff-sequences@^24.3.0: version "24.3.0" resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-24.3.0.tgz#0f20e8a1df1abddaf4d9c226680952e64118b975" @@ -7641,6 +7636,11 @@ leven@^2.1.0: resolved "https://registry.yarnpkg.com/leven/-/leven-2.1.0.tgz#c2e7a9f772094dee9d34202ae8acce4687875580" integrity sha1-wuep93IJTe6dNCAq6KzORoeHVYA= +leven@^3.1.0: + version "3.1.0" + resolved "https://registry.yarnpkg.com/leven/-/leven-3.1.0.tgz#77891de834064cccba82ae7842bb6b14a13ed7f2" + integrity sha512-qsda+H8jTaUaN/x5vzW2rzc+8Rw4TAQ/4KjB46IwK5VH+IlVeeeje/EoZRpiXvIqjFgK84QffqPztGI3VBLG1A== + levn@^0.3.0, levn@~0.3.0: version "0.3.0" resolved "https://registry.yarnpkg.com/levn/-/levn-0.3.0.tgz#3b09924edf9f083c0490fdd4c0bc4421e04764ee" From b11d7cc1db0baea3239b35c2f4640ea12e88c7aa Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 13 Feb 2020 15:40:27 +0530 Subject: [PATCH 2/2] fix: lint --- packages/cli/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts index d378c6cec..ce949e27d 100644 --- a/packages/cli/src/index.ts +++ b/packages/cli/src/index.ts @@ -87,7 +87,7 @@ function printHelpInformation( function printUnknownCommand(cmdName: string) { const availableCommands = commander.commands.map(cmd => cmd._name); const suggestion = availableCommands.find(cmd => { - return leven(cmd, cmdName) < 3; + return leven(cmd, cmdName) < 3; }); let errorMsg = `Unrecognized command "${chalk.bold(cmdName)}".`; if (suggestion) {