Skip to content

Fix: If versionsToShow is not an array, return N/A #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 16, 2020
Merged

Fix: If versionsToShow is not an array, return N/A #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d96b68
If versionsToShow is not an array, return N/A
ph0ph0 Feb 14, 2020
cac45ba
If versionsToShow is not an array, return N/A
ph0ph0 Feb 14, 2020
f2508ec
Merge branch 'versionsToShow' of https://github.com/ph0ph0/cli into v…
ph0ph0 Feb 15, 2020
91bd34c
ran yarn lint --fix
ph0ph0 Feb 15, 2020
b987714
updated HealthCheckResult types to account for versions being either …
ph0ph0 Feb 16, 2020
9fbf1a9
deleted unneeded history file
ph0ph0 Feb 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/cli/src/commands/doctor/doctor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ const printCategory = ({label, key}: {label: string; key: number}) => {

const printVersions = ({version, versions, versionRange}) => {
if (versions) {
const versionsToShow = versions.join(', ');
const versionsToShow = Array.isArray(versions)
? versions.join(', ')
: 'N/A';
Copy link
Member

@thymikee thymikee Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the HealthCheckResult types to account for this type, so we can avoid similar issues in the future

Copy link
Contributor Author

@ph0ph0 ph0ph0 Feb 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thymikee, thanks very much for the pointers, I have made the changes :) Thanks!


logMessage(`- Versions found: ${chalk.red(versionsToShow)}`);
logMessage(`- Version supported: ${chalk.green(versionRange)}`);
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/doctor/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export type HealthCheckResult = {
label: string;
needsToBeFixed: boolean;
version?: 'Not Found' | string;
versions?: [string];
versions?: [string] | string;
versionRange?: string;
description: string | undefined;
runAutomaticFix: RunAutomaticFix;
Expand Down