Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(android): add videoBitrate option for recordAsync #2055
While VideoQuality can be set, this option does not give developers anyway to fine-tune the resulting file size of a recorded video. 720p recording will use a 12 Mbps bitrate on a Galaxy S8+, even though 720p should be closer to 5 Mbps.
Introducing a new optional recording option helps to solve this problem.
Example of calling it from React Native
It falls back to default behavior, as if this code was never implemented.…
On Jan 16, 2019, at 10:44 AM, Sibelius Seraphini ***@***.***> wrote: @sibelius approved this pull request. What happens when user does not pass it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2055 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AlQSbczqNFFQN3vwWqMC3GM1GOV9tXDAks5vD1bVgaJpZM4aDelH>.