Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Photos - Make Returns Consistent #137

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Delete Photos - Make Returns Consistent #137

merged 1 commit into from
Feb 5, 2020

Conversation

thekevinbrown
Copy link
Contributor

Summary

Delete photos returns a promise in the underlying implementation, currently a boolean on iOS and null on Android.

This PR makes them both return a boolean, and updates the Typescript types to match.

Test Plan

Best tested in an application.

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@bartolkaruza bartolkaruza merged commit b49dc8e into react-native-cameraroll:master Feb 5, 2020
bartolkaruza pushed a commit that referenced this pull request Feb 5, 2020
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
34444b2 
# [1.4.0](v1.3.1...v1.4.0) (2020-02-05)

### Bug Fixes

* Making Promise return types consistent across iOS and Android, updating types to match. ([#137](#137)) ([b49dc8e](b49dc8e))

### Features

* Support filter media items between dates ([#140](#140)) ([75b4208](75b4208))
@bartolkaruza
Copy link
Collaborator

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartolkaruza bartolkaruza bartolkaruza approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekevinbrown @bartolkaruza