Fix #97 Android 10 screenshot sorted incorrectly #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartolkaruza
pushed a commit
that referenced
this pull request
Nov 7, 2019
# [1.3.0](v1.2.1...v1.3.0) (2019-11-07) ### Bug Fixes * **example:** remove flow parsing from example ([452fd7b](452fd7b)) * **lib:** Android 10 screenshot sorted incorrectly ([#98](#98)) ([902abd4](902abd4)), closes [#97](#97) * **lib:** Fix warning for deprecated RCTBridge interface for RCTImageLoader ([#87](#87)) ([c0a132d](c0a132d)) ### Features * **lib:** Moved deletePhotos to use new PHAsset API and added an implementation for Android ([#69](#69)) ([7850dd5](7850dd5))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix outlined in #97
Summary
Screenshots taken in Android 10 are no longer tagged with DATE_TAKEN but only DATE_ADDED. This causes screenshots taken in Android 10 to appear at the bottom of a potentially very long list.
Test Plan
I have no solid test plan. I've tested it locally.
What's required for testing (prerequisites)?
A photo library with at least 10 items, to clearly see how screenshots are shown last.
What are the steps to reproduce (after prerequisites)?
See issue
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)