Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking fails on react-native 0.49.3 #251

Closed
ggozad opened this Issue Oct 16, 2017 · 14 comments

Comments

Projects
None yet
9 participants
@ggozad
Copy link

ggozad commented Oct 16, 2017

After installing and linking react-native-device-info I get the following error with an upgraded react-native

ld: library not found for -lRNDeviceInfo-tvOS
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I guess this is because of the automatic tvOS inclusion on rn. Any workarounds or ways to fix?

@baijunjie

This comment has been minimized.

Copy link

baijunjie commented Oct 16, 2017

Same question

@cristianosantos95

This comment has been minimized.

Copy link

cristianosantos95 commented Oct 16, 2017

  • open xcode
  • project target
  • build phases
  • link binary with libraries
  • remove libRNDeviceInfo-tvOS.a

it worked for me :)

@cyzaoj

This comment has been minimized.

Copy link

cyzaoj commented Oct 25, 2017

What time the bug version

@XeeshanAnsari

This comment has been minimized.

Copy link

XeeshanAnsari commented Oct 27, 2017

remove libRNDeviceinfo-tvOS.a
it also worked for me.

@lindseymenges

This comment has been minimized.

Copy link

lindseymenges commented Nov 17, 2017

I've been banging my head against the wall all day with this issue, and removing libRNDeviceinfo-tvOS.a finally did the trick. Thanks @cristianosantos95 !

@GantMan

This comment has been minimized.

Copy link
Member

GantMan commented Nov 20, 2017

Anyone want to see if they can code this fix?

@machour

This comment has been minimized.

Copy link
Collaborator

machour commented Jan 30, 2018

@GantMan Seems to be handled in this PR #283

@GantMan

This comment has been minimized.

Copy link
Member

GantMan commented Jan 30, 2018

Merged!
@machour - any suggested PRs / cleanup before I release an updated version?

@machour

This comment has been minimized.

Copy link
Collaborator

machour commented Jan 30, 2018

re #283: target seems to have changed from 7.0 to 9.0, not sure that's a good thing (not an iOS expert by any means)
#280: seems harmless enough to me to be merged
#297: needs to make it to README.md

and last but not least, the missing ChangeLogs (including the one for the pending release)

❤️

@GantMan

This comment has been minimized.

Copy link
Member

GantMan commented Jan 30, 2018

plz PR the changelogs! I'll merge and then do a release

@machour

This comment has been minimized.

Copy link
Collaborator

machour commented Jan 30, 2018

Et voilà : #301
Don't forget to bump the version in here as well: https://github.com/rebeccahughes/react-native-device-info/blob/master/RNDeviceInfo.podspec

@machour

This comment has been minimized.

Copy link
Collaborator

machour commented Feb 3, 2018

This should now work fine in 0.14.0

@machour machour closed this Feb 3, 2018

@machour

This comment has been minimized.

Copy link
Collaborator

machour commented Feb 3, 2018

FYI, issue isn't solved in 0.14.0, but is already tracked in #258. Leaving this issue closed.

@riheldo

This comment has been minimized.

Copy link

riheldo commented Mar 10, 2018

Well, my issue was diferent, but remove libRNDeviceinfo-tvOS.a works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.