Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Detox test foundations #17

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@matt-oakes
Copy link
Collaborator

commented Apr 3, 2019

Overview

Adds the foundations of Detox testing. Currently, this only does the sanity checks to ensure everything is set up correctly.

Note: We need to downgrade the example project to React Native 0.58 as this is the lates that Detox supports on Android. See wix/Detox#1233.

Test Plan

CircleCI tests should pass.

@matt-oakes matt-oakes force-pushed the @matt-oakes/detox branch from 01e7b40 to c3a2e1e Apr 3, 2019

@matt-oakes matt-oakes force-pushed the @matt-oakes/detox branch from c3a2e1e to fa7ec3c Apr 3, 2019

@matt-oakes matt-oakes marked this pull request as ready for review Apr 3, 2019

@matt-oakes matt-oakes changed the title WIP: Add the Detox test foundations Add the Detox test foundations Apr 3, 2019

@michalchudziak
Copy link
Collaborator

left a comment

Great job! Thank you a lot 😁

@michalchudziak michalchudziak merged commit af356af into master Apr 4, 2019

6 checks passed

ci/circleci: analyse Your tests passed on CircleCI!
Details
ci/circleci: android_test Your tests passed on CircleCI!
Details
ci/circleci: build_android_debug Your tests passed on CircleCI!
Details
ci/circleci: build_android_release Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: ios_build_and_test Your tests passed on CircleCI!
Details

@matt-oakes matt-oakes deleted the @matt-oakes/detox branch Apr 4, 2019

@react-native-community-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.