Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Zoom Controls visibility on the map #1906

Merged
merged 8 commits into from Dec 21, 2017

Conversation

Projects
None yet
3 participants
@timotew
Copy link
Contributor

commented Dec 20, 2017

Manage Map Zoom controls, Disabling zoom and zoom controls can also be used to disable double tap zoom gesture as suggested in #1133

@timotew timotew closed this Dec 20, 2017

@timotew timotew reopened this Dec 20, 2017

@timotew

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2017

@rborn how are we to handle this Good First PR?

@rborn

This comment has been minimized.

Copy link
Collaborator

commented Dec 21, 2017

@timotew I'm a little overloaded right now, I'll review as soon as I have some spare time 🤗
Shouldn't take too long.

@rborn rborn self-requested a review Dec 21, 2017

@rborn
Copy link
Collaborator

left a comment

@rborn rborn merged commit 7a39498 into react-native-community:master Dec 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rborn

This comment has been minimized.

Copy link
Collaborator

commented Dec 21, 2017

@timotew great stuff, thanks a lot!

@timotew

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2017

@rborn Thank you for taking your time to attend to this.

xeoh added a commit to zigbang/react-native-maps that referenced this pull request Jan 8, 2018

Merge branch 'master' into zigbang
* master: (63 commits)
  Update MapOverlay.js (react-native-community#1927)
  Merge Ground Overlay Support (PR-1586) (react-native-community#1918)
  fixed polyline example
  default export is MapView (react-native-community#1904)
  Add gradient/multi-color polyline support for iOS (MapKit) (react-native-community#1911)
  Update issues template with no_template warning (react-native-community#1917)
  change name of project (react-native-community#1910)
  Updated installation guide with Xcode 8 possible error
  Manage Zoom Controls visibility on the map  (react-native-community#1906)
  Fixed minor styling issues in installation guide (react-native-community#1905)
  corrected default value to ``round`` (react-native-community#1898)
  Corrected doc text for Polyline (react-native-community#1899)
  Fixed onMapReady no longer getting called on iOS (react-native-community#1853)
  Fix example with animated markers (react-native-community#1840)
  Update installation.md (react-native-community#1892)
  Update for Animated.Region react-native-community#24 Fix on the AnimatedMarkers Example  (react-native-community#1889)
  v0.19.0
  Update examples-setup.md (react-native-community#1888)
  Fix main install docs (react-native-community#1887)
  Revert "Merge pull request #1 from react-community/master"
  ...

kdong007 pushed a commit to hetaoai/react-native-maps that referenced this pull request Jan 19, 2018

Manage Zoom Controls visibility on the map (react-native-community#1906)
* Manage Zoom Controls visibility on the map

* Manage Zoom Controls visibility on the map

* Manage Zoom Controls visibility on the map

* Manage Zoom Controls visibility on the map

* Manage Zoom Controls visibility on the map

* Manage Zoom Controls visibility on the map

* Manage Zoom Controls visibility on the map

* Manage Zoom Controls not available on iOS SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.