Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native animation for Markers on Android (with documentation) #1976

Merged
merged 5 commits into from Jan 22, 2018

Conversation

Projects
None yet
5 participants
@BEGEMOT9I
Copy link
Contributor

BEGEMOT9I commented Jan 19, 2018

This is a copy of #1782 with documentation.

@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Jan 19, 2018

LGTM
@alvelig 🐽

@alvelig

This comment has been minimized.

Copy link
Collaborator

alvelig commented Jan 19, 2018

BEGEMOT9I
@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Jan 22, 2018

@BEGEMOT9I could you please fix the things travis is complaining ? 🤗

BEGEMOT9I added some commits Jan 22, 2018

BEGEMOT9I
BEGEMOT9I
@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Jan 22, 2018

LGTM @alvelig 🐽

@alvelig

This comment has been minimized.

Copy link
Collaborator

alvelig commented Jan 22, 2018

Great! LGTM

@rborn rborn merged commit 8363c7c into react-native-community:master Jan 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

xeoh added a commit to zigbang/react-native-maps that referenced this pull request Jan 29, 2018

Merge commit '921fffb8c4ea0cb1760b7389af254715aaeb3076' into zigbang
* commit '921fffb8c4ea0cb1760b7389af254715aaeb3076': (23 commits)
  add markers not to AirMapView but to MKAnnotationView (fixes some zIndex issues)
  Refactoring Map.Overlay for android
  Add native animation for Markers on Android (with documentation) (react-native-community#1976)
  Add comment suggesting to deprecate other components being set as properties on MapView
  Events example: Call event.persist() where appropriate to avoid synthetic events being recycled before setState occurs
  Update examples and documentation to use new es6 exports
  Don't change npm dependency versions
  Make babel-plugin-module-resolver and babel-preset-react-native runtime dependencies
  Switch to using es6 exports
  Android polygon holes support (react-native-community#1781)
  iOS google map fixes (react-native-community#1953)
  Fixed gradient polyline not always fully drawn + crashes (react-native-community#1960)
  Added tracksViewChanges description to marker docs (react-native-community#1968)
  Added tracksInfoWindowChanges property to iOS Google Maps (react-native-community#1969)
  Update README.md
  Fix docs for run examples
  Fix build example for android
  [docs] Clarify that mutedStandard is only supported starting in iOS 11 (react-native-community#1962)
  Fix callouts appearing behind markers (react-native-community#1846)
  Add missing import on AirMapModule.java (react-native-community#1958)
  ...

# Conflicts:
#	example/App.js
#	lib/ios/AirGoogleMaps/AIRGoogleMapMarker.m
@henninghall

This comment has been minimized.

Copy link

henninghall commented Feb 6, 2018

Great improvement! What about iOS, is it already using native drivers for marker animations?

@dagostal

This comment has been minimized.

Copy link

dagostal commented Mar 29, 2018

Hi - I am a noob, when i implement this i get an error "expected dynamic type 'double' but had type 'null' (constructing aruments for UIManger.dispatchViewManagerCommand at argument index 1.

I am putting the correct arguments into the function- Any idea?
Thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.