Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for KML file (Only Markers) #2011

Merged
merged 16 commits into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@rafaellincoln
Copy link
Contributor

commented Feb 2, 2018

Adds support for make marker with KML files.
Discussion on implementation at #967

@@ -142,7 +143,7 @@ class App extends React.Component {
[DefaultMarkers, 'Default Markers', true],
[CustomMarkers, 'Custom Markers', true],
[TakeSnapshot, 'Take Snapshot', true, '(incomplete)'],
[CachedMap, 'Cached Map'],
[CachedMap, 'Cached Map', true],

This comment has been minimized.

Copy link
@alvelig

alvelig Feb 2, 2018

Collaborator

Why?

This comment has been minimized.

Copy link
@rafaellincoln

rafaellincoln Feb 2, 2018

Author Contributor

Returned to old value

@@ -22,7 +22,7 @@
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
<meta-data
android:name="com.google.android.geo.API_KEY"
android:value="AIzaSyBAefhRlXEH3vCko-zZTX6PHllTR6av4WI"/>
android:value="AIzaSyAJVwyHn6klk0_aoEL1oEysTOYn0jrRU1c"/>

This comment has been minimized.

Copy link
@alvelig

alvelig Feb 2, 2018

Collaborator

Why? )) Does the old key work, doesn't it?

This comment has been minimized.

Copy link
@rafaellincoln

rafaellincoln Feb 2, 2018

Author Contributor

Returned to old value

@@ -18,4 +18,5 @@ Pod::Spec.new do |s|

s.dependency 'React'
s.dependency 'GoogleMaps', '2.5.0'
s.dependency 'Google-Maps-iOS-Utils', '2.1.0'

This comment has been minimized.

Copy link
@alvelig

alvelig Feb 2, 2018

Collaborator

What do you need it for?

This comment has been minimized.

Copy link
@rafaellincoln

rafaellincoln Feb 2, 2018

Author Contributor

I need it to convert the kml tags to Object

This comment has been minimized.

Copy link
@alvelig

alvelig Feb 2, 2018

Collaborator

Ah, I see now :)

 +#import "GMUKMLParser.h"
 +#import "GMUPlacemark.h"
 +#import "GMUPoint.h"
 +#import "GMUGeometryRenderer.h"
@alvelig

This comment has been minimized.

Copy link
Collaborator

commented Feb 2, 2018

Great! Thank you for the contribution!!! LGTM

@rborn @christopherdro 🐽

@rborn
Copy link
Collaborator

left a comment

Other than the docs comment, LGTM

@@ -35,6 +35,7 @@
| `loadingBackgroundColor` | `Color` | `#FFFFFF` | Sets loading background color, default to `#FFFFFF`.
| `moveOnMarkerPress` | `Boolean` | `true` | `Android only` If `false` the map won't move when a marker is pressed.
| `legalLabelInsets` | `EdgeInsets` | | If set, changes the position of the "Legal" label link from the OS default. **Note:** iOS only.
| `kmlSrc` | `string` | | The URL from KML file. **Note:** Google Maps only (either Android or iOS with `PROVIDER_GOOGLE`).

This comment has been minimized.

Copy link
@rborn

rborn Feb 13, 2018

Collaborator

You say in the PR that it's markers only maybe we should specify this in the docs?

This comment has been minimized.

Copy link
@rafaellincoln

rafaellincoln Feb 23, 2018

Author Contributor

Docs updated.

@rafaellincoln rafaellincoln force-pushed the rafaellincoln:master branch from 8742a7d to 2595a23 Feb 20, 2018

@rborn

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2018

@rafaellincoln could you please fix the conflicts and #2011 (comment) 🤗

@rborn rborn added the waiting reply label Feb 22, 2018

@rafaellincoln

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2018

@rborn Fixed conflicts

@rborn rborn merged commit d22f96f into react-native-community:master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pedrolopes10

This comment has been minimized.

Copy link

commented Apr 21, 2018

Hi there, @rafaellincoln thanks for this functionality! I've run the example that's in the docs (MapKml.js) but I can only see the markers running it on Android Studio, when running it on Genymotion it doesn't show nothing. @rborn can you confirm it?

Also, it says (only markers) why? It works great with lines (LinearRing)!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.