Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some typescript issues #2035

Merged
merged 3 commits into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@AlmirKadric
Copy link
Contributor

AlmirKadric commented Feb 20, 2018

Fixed a few typescript issues I found when using the package within our project. Also exposed Animated versions of the components so that ES6 import statements can be used on them too.

@AlmirKadric AlmirKadric force-pushed the AlmirKadric:master branch 2 times, most recently from a1fd954 to ff9c9ab Feb 20, 2018

@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Feb 20, 2018

@AlmirKadric LGTM but there are conflicts due to the last merge I think. Could you please fix them 🤗

@AlmirKadric AlmirKadric force-pushed the AlmirKadric:master branch from ff9c9ab to c6ddc89 Feb 20, 2018

AlmirKadric added some commits Feb 20, 2018

@AlmirKadric

This comment has been minimized.

Copy link
Contributor Author

AlmirKadric commented Feb 20, 2018

@rborn sorry i didn't notice the lint error, should all be fine now

@rborn rborn merged commit 7c83231 into react-native-community:master Feb 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.