Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed re-render not updating MapView.Circle component in UI when radius or center coordinates change. #2101

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@AustinHunt
Copy link
Contributor

commented Mar 15, 2018

Does any other open PR do the same thing?

Not currently.

What issue is this PR fixing?

The circle will not re-render when radius or center changes. This is due to a simple mistake in AIRMap.m

#187 (comment)

How did you test this PR?

Tested by creating a project in which the radius and lat/lng values can be changed dynamically. When these values change, the corresponding re-render updates the view to match the new values.

@AustinHunt AustinHunt referenced this pull request Mar 15, 2018

Merged

Fix Circle overlay #187

@rborn rborn merged commit afa4bfa into react-native-community:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AustinHunt AustinHunt deleted the AustinHunt:circle-rerender-fix branch Mar 15, 2018

rostislav-simonik added a commit to technology-studio-forks/react-native-maps that referenced this pull request Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.