Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lineCap and lineDash pattern #2417

Merged
merged 10 commits into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@kruyvanna
Copy link
Contributor

kruyvanna commented Aug 8, 2018

Does any other open PR do the same thing?

Yes. But this one does one more thing which is LineDashPattern
(please answer here)

What issue is this PR fixing?

No issue reported yet.
(please link the issue here)

How did you test this PR?

Tested.

You're welcome

@christopherdro

This comment has been minimized.

Copy link
Collaborator

christopherdro commented Jan 8, 2019

@kruyvanna Thanks for the PR. Any chance you can add this information to the docs?

@kruyvanna

This comment has been minimized.

Copy link
Contributor Author

kruyvanna commented Feb 3, 2019

@christopherdro I updated the docs.

@@ -97,6 +98,12 @@ public void setlineCap(AirMapPolyline view, String lineCap) {
view.setLineCap(cap);
}

@ReactProp(name = "lineDashPattern")
public void setLineDashPattern(AirMapPolyline view, ReadableArray patternValues) {
Log.i("VANNA", "setLineDash " + patternValues);

This comment has been minimized.

Copy link
@christopherdro

christopherdro Feb 6, 2019

Collaborator

@kruyvanna Could you remove this log here?

@christopherdro

This comment has been minimized.

Copy link
Collaborator

christopherdro commented Feb 6, 2019

@kruyvanna Thank you. Just left one more comment to remove a debug log left behind.

@kruyvanna

This comment has been minimized.

Copy link
Contributor Author

kruyvanna commented Feb 14, 2019

@@ -4,6 +4,7 @@
import android.graphics.Color;
import android.os.Build;
import android.util.DisplayMetrics;
import android.util.Log;

This comment has been minimized.

Copy link
@salah-ghanim

salah-ghanim Mar 6, 2019

Collaborator

@kruyvanna please remove this import

once done I'm more than happy to test and merge

@kruyvanna

This comment has been minimized.

Copy link
Contributor Author

kruyvanna commented Mar 8, 2019

@christopherdro christopherdro merged commit 4978696 into react-native-community:master Mar 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.