Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fitToSuppliedMarkers function #2524

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@marcelkalveram
Copy link
Contributor

commented Oct 1, 2018

Fixes #2513

Does any other open PR do the same thing?

#2520

seems to fix the same issue

What issue is this PR fixing?

#2513

How did you test this PR?

iOS simulator. Builds were failing without this fix.

@marcelkalveram

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2018

btw: the bug got originally introduced here: #2479

@rborn

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2018

@marcelkalveram do we need to adjust docs too?

@marcelkalveram

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2018

@rborn this doesn't work with Apple Maps (only Google, both Android and iOS), as mentioned in my previous PR. Not sure if this is something that should be mentioned in the docs? At least, after this PR, it shouldn't fail anymore with Apple Maps.

@rborn

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2018

We should mention that it only works with google maps or we'll get a lot of issues reported (it will be, trust me).
So if the docs need to be amended please do so and I'll merge asap.
Thank you ❤️

@rborn

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2018

@marcelkalveram I'll merge this

@rborn rborn merged commit 1aee143 into react-native-community:master Oct 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

salah-ghanim pushed a commit to GET-A-WAY/react-native-maps that referenced this pull request Oct 16, 2018

ryanbourneuk pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Dec 10, 2018

Ryan Bourne
Merge remote-tracking branch 'upstream/master'
* upstream/master: (28 commits)
  Calculate bounding box from region (react-native-community#2615)
  [iOS GoogleMap] Fix animateCamera (react-native-community#2608)
  Fix type definition error (react-native-community#2607)
  [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-community#2598)
  Provide a camera system (react-native-community#2563)
  Get visible map bounding box (react-native-community#2571)
  [0.22.1] Release (react-native-community#2574)
  Move dev only deps to devDependencies. (react-native-community#2548)
  Specify how to use Google Maps (react-native-community#2550)
  r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-community#2555)
  update to clarify cacheEnabled is apple maps only
  [0.22.0] Release (react-native-community#2535)
  Fix for “The specified child already has a parent”
  Improve installation docs (react-native-community#2541)
  fix fitToSuppliedMarkers function (react-native-community#2524)
  Performance improvements for tracksViewChanges (react-native-community#2487)
  fix spelling mistakes
  Added flag to make sure that there has an Observer of view.
  hotfix PR react-native-community#2478
  Fix a peer dependencies warning
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.